Bug 136642 - Always update the referrer header in CachedResource
Summary: Always update the referrer header in CachedResource
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-08 13:20 PDT by jochen
Modified: 2014-09-08 14:22 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.73 KB, patch)
2014-09-08 13:21 PDT, jochen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2014-09-08 13:20:22 PDT 
Always update the referrer header in CachedResource
Comment 1 jochen 2014-09-08 13:21:36 PDT 
Created attachment 237807 [details]
Patch
Comment 2 jochen 2014-09-08 13:24:14 PDT 
not sure how to test this. I added a similar patch in chromium here https://codereview.chromium.org/534233002, however, the loader code has diverged considerably meanwhile.
Comment 3 Alexey Proskuryakov 2014-09-08 13:36:37 PDT 
Comment on attachment 237807 [details]
Patch

Seems like a reasonable improvement for code clarity and robustness, even if it doesn't fix anything real in WebKit.
Comment 4 WebKit Commit Bot 2014-09-08 14:22:27 PDT 
Comment on attachment 237807 [details]
Patch

Clearing flags on attachment: 237807

Committed r173398: <http://trac.webkit.org/changeset/173398>
Comment 5 WebKit Commit Bot 2014-09-08 14:22:31 PDT 
All reviewed patches have been landed.  Closing bug.