Bug 136625 - [CSS Grid Layout] Ignore ::first-letter pseudo-element
Summary: [CSS Grid Layout] Ignore ::first-letter pseudo-element
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
Depends on:
Blocks: 60731
  Show dependency treegraph
Reported: 2014-09-08 04:49 PDT by Manuel Rego Casasnovas
Modified: 2014-09-09 14:58 PDT (History)
12 users (show)

See Also:

Patch (12.16 KB, patch)
2014-09-08 07:44 PDT, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff
Patch (12.17 KB, patch)
2014-09-08 12:16 PDT, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff
Patch (12.16 KB, patch)
2014-09-09 14:14 PDT, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2014-09-08 04:49:25 PDT
According to the spec the ::first-line pseudo-element do not apply to grid containers (neither to flexboxes).

This is not working as expected in all the situations, so I'll provide a patch to fix the issues.

This has already landed in Blink: https://src.chromium.org/viewvc/blink?view=rev&revision=180043
Comment 1 Manuel Rego Casasnovas 2014-09-08 07:44:04 PDT
Created attachment 237786 [details]
Comment 2 Darin Adler 2014-09-08 08:04:23 PDT
Comment on attachment 237786 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=237786&action=review

> Source/WebCore/rendering/RenderBlock.cpp:3022
> +static inline bool isRenderBlockFlowOrRenderButton(RenderObject* renderObject)

This function should take a RenderElement&, not a RenderObject*.
Comment 3 Manuel Rego Casasnovas 2014-09-08 12:16:27 PDT
Created attachment 237801 [details]
Comment 4 WebKit Commit Bot 2014-09-09 14:10:29 PDT
Comment on attachment 237801 [details]

Rejecting attachment 237801 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 237801, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/5866952681586688
Comment 5 Manuel Rego Casasnovas 2014-09-09 14:14:25 PDT
Created attachment 237856 [details]
Comment 6 WebKit Commit Bot 2014-09-09 14:58:22 PDT
Comment on attachment 237856 [details]

Clearing flags on attachment: 237856

Committed r173444: <http://trac.webkit.org/changeset/173444>
Comment 7 WebKit Commit Bot 2014-09-09 14:58:27 PDT
All reviewed patches have been landed.  Closing bug.