Bug 136620 - [SVG] Experiment: Disable SVG animated DOM properties
Summary: [SVG] Experiment: Disable SVG animated DOM properties
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-08 01:17 PDT by Dirk Schulze
Modified: 2016-10-05 18:58 PDT (History)
25 users (show)

See Also:


Attachments
Patch (110.32 KB, patch)
2014-09-08 01:55 PDT, Dirk Schulze
no flags Details | Formatted Diff | Diff
Patch (109.84 KB, patch)
2014-09-08 02:21 PDT, Dirk Schulze
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (573.08 KB, application/zip)
2014-09-08 05:28 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (573.92 KB, application/zip)
2014-09-08 06:22 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (575.88 KB, application/zip)
2014-09-08 07:30 PDT, Build Bot
no flags Details
Patch (109.99 KB, patch)
2014-09-08 08:11 PDT, Dirk Schulze
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2014-09-08 01:17:37 PDT
We want to explore if it is worth maintaining SVG DOM. Can we remove SVG DOM is there something that we need to keep around? If the experiment completely fails, we unroll the changes and know how the SVG WG should proceed with SVG2.
Comment 1 Dirk Schulze 2014-09-08 01:55:10 PDT
Created attachment 237767 [details]
Patch
Comment 2 Dirk Schulze 2014-09-08 02:21:54 PDT
Created attachment 237769 [details]
Patch
Comment 3 Build Bot 2014-09-08 05:28:49 PDT
Comment on attachment 237769 [details]
Patch

Attachment 237769 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5437169531355136

New failing tests:
http/tests/misc/acid3.html
http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded-svg.svg
Comment 4 Build Bot 2014-09-08 05:28:55 PDT
Created attachment 237779 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 5 Build Bot 2014-09-08 06:22:29 PDT
Comment on attachment 237769 [details]
Patch

Attachment 237769 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4660079487877120

New failing tests:
http/tests/misc/acid3.html
http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded-svg.svg
Comment 6 Build Bot 2014-09-08 06:22:38 PDT
Created attachment 237780 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 7 Build Bot 2014-09-08 07:29:53 PDT
Comment on attachment 237769 [details]
Patch

Attachment 237769 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6549517742637056

New failing tests:
http/tests/misc/acid3.html
http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded-svg.svg
Comment 8 Build Bot 2014-09-08 07:30:03 PDT
Created attachment 237785 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 9 Dirk Schulze 2014-09-08 08:11:43 PDT
Created attachment 237788 [details]
Patch
Comment 10 Dirk Schulze 2014-09-08 08:54:32 PDT
(In reply to comment #9)
> Created an attachment (id=237788) [details]
> Patch

ACID3 will be broken since it checks for SVGRectElement support by asserting rect.width, which this patch removes. A bad check anyway IMO but probably reasonable at the time.
Comment 11 Alexey Proskuryakov 2014-09-08 23:35:37 PDT
This sounds like something that many people on webkit-dev would love to be notified about. Could you please send an e-mail?
Comment 12 Sam Weinig 2014-09-09 16:51:06 PDT
(In reply to comment #0)
> We want to explore if it is worth maintaining SVG DOM. Can we remove SVG DOM is there something that we need to keep around? If the experiment completely fails, we unroll the changes and know how the SVG WG should proceed with SVG2.

Who is the we here? What data do you plan on collecting to confirm/reject your hypothesis?
Comment 13 Michael Catanzaro 2016-09-17 07:07:56 PDT
Comment on attachment 237788 [details]
Patch

Hi,

Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting.

To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug.