There is a crash as soon as Minibrowser runs on debug mode. gyuyoung@gyuyoung-MacBookPro:~/WebKit$ WebKitBuild/Debug/bin/MiniBrowser HTML5 local storage is enabled for this view. ERR<3506>:efreet_cache lib/efreet/efreet_cache.c:1108 on_send_register() org.freedesktop.DBus.Error.ServiceUnknown The name org.enlightenment.Efreet was not provided by any .service files ASSERTION FAILED: !window /home/gyuyoung/WebKit/Source/WebCore/platform/efl/EflScreenUtilities.cpp(113) : void WebCore::applyCursorFromEcoreX(Ecore_X_Window, const char*) 1 0x7f02fabbcfdd WTFCrash 2 0x7f02f65b8a97 WebCore::applyCursorFromEcoreX(unsigned int, char const*) 3 0x7f02fdd47a94 EwkView::updateCursor(unsigned int) 4 0x7f02fdd47c3c EwkView::setCursor(WebCore::Cursor const&) 5 0x7f02fddb95c4 WebKit::WebViewEfl::setCursor(WebCore::Cursor const&) 6 0x7f02fdb2c2ab WebKit::WebPageProxy::setCursor(WebCore::Cursor const&) 7 0x7f02fde05407 void IPC::callMemberFunctionImpl<WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(WebCore::Cursor const&), std::tuple<WebCore::Cursor>, 0ul>(WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)(WebCore::Cursor const&), std::tuple<WebCore::Cursor>&&, std::index_sequence<0ul>) 8 0x7f02fde014d8 void IPC::callMemberFunction<WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(WebCore::Cursor const&), std::tuple<WebCore::Cursor>, std::make_index_sequence<1ul> >(std::tuple<WebCore::Cursor>&&, WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)(WebCore::Cursor const&)) 9 0x7f02fddf5fdf void IPC::handleMessage<Messages::WebPageProxy::SetCursor, WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(WebCore::Cursor const&)>(IPC::MessageDecoder&, WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)(WebCore::Cursor const&)) 10 0x7f02fddf08d2 WebKit::WebPageProxy::didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) 11 0x7f02fda1f62e IPC::MessageReceiverMap::dispatchMessage(IPC::Connection*, IPC::MessageDecoder&) 12 0x7f02fda3c7e7 WebKit::ChildProcessProxy::dispatchMessage(IPC::Connection*, IPC::MessageDecoder&) 13 0x7f02fdb651c7 WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) 14 0x7f02fda0eae0 IPC::Connection::dispatchMessage(IPC::MessageDecoder&) 15 0x7f02fda0ebac IPC::Connection::dispatchMessage(std::unique_ptr<IPC::MessageDecoder, std::default_delete<IPC::MessageDecoder> >) 16 0x7f02fda0ed6d IPC::Connection::dispatchOneMessage() 17 0x7f02fda1ea1f WTF::FunctionWrapper<void (IPC::Connection::*)()>::operator()(IPC::Connection*) 18 0x7f02fda1e792 WTF::BoundFunctionImpl<WTF::FunctionWrapper<void (IPC::Connection::*)()>, void (IPC::Connection*)>::operator()() 19 0x7f02fda1799d WTF::Function<void ()>::operator()() const 20 0x7f02fda13e65 std::_Function_handler<void (), WTF::Function<void ()> >::_M_invoke(std::_Any_data const&) 21 0x7f02fda275a0 std::function<void ()>::operator()() const 22 0x7f02fde47ba1 WTF::RunLoop::performWork() 23 0x7f02fde48d94 WTF::RunLoop::wakeUpEvent(void*, void*, unsigned int) 24 0x7f02fcb2f07f 25 0x7f02fcb2f80a 26 0x7f02fcb2e811 27 0x7f02fcb2ea17 ecore_main_loop_begin 28 0x40caf5 elm_main 29 0x40cb68 main 30 0x7f02fb6ccec5 __libc_start_main 31 0x4060d9 Error receiving IPC message on socket 27 in process 3537: Connection reset by peer Segmentation fault (core dumped) gyuyoung@gyuyoung-MacBookPro:~/WebKit$ LEAK: 1 WebPage LEAK: 1 WebFrame LEAK: 200 RenderObject LEAK: 1 Page LEAK: 1 Frame LEAK: 8 CachedResource LEAK: 4 SubresourceLoader LEAK: 287 WebCoreNode LEAK: 24 JSLazyEventListener
Created attachment 237763 [details] Patch
In applyCursorFromEcoreX(), ASSERT(!window) makes a crash though window isn't null. This is wrong ASSERT use. This patch fixes it.
Comment on attachment 237763 [details] Patch LGTM, r=me.
Just to note, this buggy assert comes from http://trac.webkit.org/changeset/173354
Comment on attachment 237763 [details] Patch Clearing flags on attachment: 237763 Committed r173373: <http://trac.webkit.org/changeset/173373>
All reviewed patches have been landed. Closing bug.