Bug 136609 - Introduce toBasicShapeFoo() instead of static_cast<BasicShapeFoo*>
Summary: Introduce toBasicShapeFoo() instead of static_cast<BasicShapeFoo*>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks: 136773
  Show dependency tree / graph
 
Reported: 2014-09-07 04:22 PDT by Gyuyoung Kim
Modified: 2014-09-11 23:20 PDT (History)
3 users (show)

See Also:

Attachments
Patch (11.53 KB, patch)
2014-09-07 04:23 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2014-09-07 04:22:47 PDT 
To use BasicShapeFoo() helps to detect wrong type casting and improve code readability.
Comment 1 Gyuyoung Kim 2014-09-07 04:23:56 PDT 
Created attachment 237753 [details]
Patch
Comment 2 Darin Adler 2014-09-07 11:37:52 PDT 
Comment on attachment 237753 [details]
Patch

Lets try again.
Comment 3 Gyuyoung Kim 2014-09-07 18:01:29 PDT 
(In reply to comment #2)
> (From update of attachment 237753 [details])
> Lets try again.

I will watch debug bot after landing this patch.
Comment 4 WebKit Commit Bot 2014-09-07 18:36:17 PDT 
Comment on attachment 237753 [details]
Patch

Clearing flags on attachment: 237753

Committed r173369: <http://trac.webkit.org/changeset/173369>
Comment 5 WebKit Commit Bot 2014-09-07 18:36:22 PDT 
All reviewed patches have been landed.  Closing bug.