Bug 136601 - Web Inspector: convert DockSide to an enum class
Summary: Web Inspector: convert DockSide to an enum class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brian Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-09-06 09:06 PDT by Brian Burg
Modified: 2014-09-06 13:52 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.42 KB, patch)
2014-09-06 09:25 PDT, Brian Burg 		no flags Details | Formatted Diff | Diff
Patch (12.44 KB, patch)
2014-09-06 12:01 PDT, Brian Burg 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-09-06 09:06:18 PDT 
splitting this off from the multi-process patch.
Comment 1 Radar WebKit Bug Importer 2014-09-06 09:06:26 PDT 
<rdar://problem/18256204>
Comment 2 Brian Burg 2014-09-06 09:25:56 PDT 
Created attachment 237739 [details]
Patch
Comment 3 Timothy Hatcher 2014-09-06 11:40:37 PDT 
Comment on attachment 237739 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237739&action=review

I was doing this in my process patch. Good to do separate.

> Source/WebCore/inspector/InspectorFrontendClient.h:46
> +        Right,

Tabs?
Comment 4 Brian Burg 2014-09-06 12:01:52 PDT 
Created attachment 237740 [details]
Patch
Comment 5 WebKit Commit Bot 2014-09-06 13:52:40 PDT 
Comment on attachment 237740 [details]
Patch

Clearing flags on attachment: 237740

Committed r173363: <http://trac.webkit.org/changeset/173363>
Comment 6 WebKit Commit Bot 2014-09-06 13:52:42 PDT 
All reviewed patches have been landed.  Closing bug.