Bug 136598 - [WinCairo][Curl] fileExists() incorrectly claims folder does not exist.
Summary: [WinCairo][Curl] fileExists() incorrectly claims folder does not exist.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-06 04:22 PDT by peavo
Modified: 2014-09-06 10:03 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.58 KB, patch)
2014-09-06 04:26 PDT, peavo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2014-09-06 04:22:10 PDT
When the fileExists() function is called in CurlCacheManager::setCacheDirectory() with a folder name ending with a slash or backslash, it will always return false, even if the folder exists.
See the documentation of FindFirstFile (http://msdn.microsoft.com/en-us/library/windows/desktop/aa364418(v=vs.85).aspx), where it's stated that it will fail if the file name ends with a backslash.
Comment 1 peavo 2014-09-06 04:26:37 PDT
Created attachment 237733 [details]
Patch
Comment 2 WebKit Commit Bot 2014-09-06 10:03:03 PDT
Comment on attachment 237733 [details]
Patch

Clearing flags on attachment: 237733

Committed r173358: <http://trac.webkit.org/changeset/173358>
Comment 3 WebKit Commit Bot 2014-09-06 10:03:05 PDT
All reviewed patches have been landed.  Closing bug.