Bug 136587 - Make Dashboard metrics time calculation work with out of order builds
Summary: Make Dashboard metrics time calculation work with out of order builds
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-05 15:46 PDT by Alexey Proskuryakov
Modified: 2014-09-07 23:18 PDT (History)
1 user (show)

See Also:

Attachments
proposed patch (3.12 KB, patch)
2014-09-05 15:51 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-09-05 15:46:10 PDT 
We have multiple bots on some queues, so results can come out of order.
Comment 1 Alexey Proskuryakov 2014-09-05 15:51:05 PDT 
Created attachment 237716 [details]
proposed patch
Comment 2 Alexey Proskuryakov 2014-09-05 16:41:39 PDT 
Comment on attachment 237716 [details]
proposed patch

I need to think more about this.

Getting a result for a newer build doesn't mean that you have a result for an older build - e.g. the new build could fail due to a new mistaken commit, so you don't know if your commit was the one that introduced the problem.
Comment 3 Alexey Proskuryakov 2014-09-07 23:18:16 PDT 
Considering how we use the dashboard, I think that this patch was right. We do not wait for all results for the bots to tell us which commit caused the problem - we just see the red, and analyze the breakage ourselves.

However, I'm going to include this change into a different patch.