Bug 136578 - CTTE: SVGResourcesCache should only allow RenderElements.
Summary: CTTE: SVGResourcesCache should only allow RenderElements.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-05 10:56 PDT by Andreas Kling
Modified: 2014-09-05 12:32 PDT (History)
12 users (show)

See Also:


Attachments
Patch (15.51 KB, patch)
2014-09-05 10:58 PDT, Andreas Kling
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-09-05 10:56:32 PDT
CTTE: SVGResourcesCache should only allow RenderElements.
Comment 1 Andreas Kling 2014-09-05 10:58:14 PDT
Created attachment 237699 [details]
Patch
Comment 2 Antti Koivisto 2014-09-05 11:18:06 PDT
Comment on attachment 237699 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237699&action=review

> Source/WebCore/rendering/svg/SVGRenderingContext.cpp:159
> +    SVGResources* resources = SVGResourcesCache::cachedResourcesForRenderer(*m_renderer);

I would use auto*
Comment 3 Andreas Kling 2014-09-05 12:32:17 PDT
Committed r173325: <http://trac.webkit.org/changeset/173325>