WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
136577
import-w3c-tests should handle paths in ref files that originate above the test file's parent dir.
https://bugs.webkit.org/show_bug.cgi?id=136577
Summary
import-w3c-tests should handle paths in ref files that originate above the te...
Rebecca Hauck
Reported
2014-09-05 10:38:55 PDT
Currently, the script assumes that the reference file originates in a subdirectory of the test file's parent directory and it is imported up N levels to be the same directory as the test. In this (most common) case, the script removes relpath from its support file paths upon import. This won't work if the reference file originated in a directory above the test file and is imported down N levels. This scenario occurs many times in the CSS test repo, but it happens to be one single shared reference file that many of the css21 tests share from a common ancestor directory. In all of these cases, the original ref file and the test file's parent dir both have the same relative path to the ref file's support file, so the new location of the ref file is a lateral move and everything 'just works'. Ideally, the import script should do the right thing wherever the the ref fileorginates, but this is an edge case and highly unlikely.
Attachments
Add attachment
proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1
2021-04-30 04:22:22 PDT
This is a real issue with flexbox tests. For that we have css/support/ css/css-flexbox/support The import script is converting every "support/" path to "../support" forcing us to manually edit the imported tests.
Sergio Villar Senin
Comment 2
2021-04-30 04:23:33 PDT
Carlos do you know if there is an "easy" fix for this or would it require a fair amount of effort?
Sergio Villar Senin
Comment 3
2021-04-30 04:25:01 PDT
I guess the problem comes from the fix from
bug 135929
?
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug