FILTERS flag is enabled on all ports. Discussion about removing this flag on webkit-dev without any objection: https://lists.webkit.org/pipermail/webkit-dev/2014-May/026553.html
Created attachment 237683 [details] Patch
Comment on attachment 237683 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237683&action=review > Source/WebCore/platform/graphics/filters/DistantLightSource.cpp:-33 > #include "config.h" > > -#if ENABLE(FILTERS) Please remove this empty line here and in all filters/*.cpp > Source/WebCore/svg/SVGComponentTransferFunctionElement.cpp:-23 > #include "config.h" > > -#if ENABLE(FILTERS) ditto > Source/WebCore/svg/SVGFEBlendElement.cpp:-24 > #include "config.h" > > -#if ENABLE(FILTERS) ditto > Source/WebCore/svg/SVGFEColorMatrixElement.cpp:-23 > #include "config.h" > > -#if ENABLE(FILTERS) ditto > Source/WebCore/svg/SVGFEComponentTransferElement.cpp:-23 > #include "config.h" > > -#if ENABLE(FILTERS) ditto ... and in all SVGFE*.cpp > Source/WebCore/svg/SVGFEDistantLightElement.cpp:23 > #include "config.h" > > -#if ENABLE(FILTERS) > #include "SVGFEDistantLightElement.h" > #include "SVGNames.h" #include "config.h" #include "SVGFEDistantLightElement.h" #include "SVGNames.h" > Source/WebCore/svg/SVGFEFuncAElement.cpp:24 > #include "config.h" > > -#if ENABLE(FILTERS) > #include "SVGFEFuncAElement.h" > #include "SVGNames.h" ditto > Tools/Scripts/webkitperl/FeatureList.pm:-234 > - { option => "filters", desc => "Toggle Filters support", > - define => "ENABLE_FILTERS", default => (isAppleWebKit() || isIOSWebKit() || isGtk() || isEfl()), value => \$filtersSupport }, > - Please remove the $filtersSupport variable too. (and the leftover $cssFiltersSupport variable too) > LayoutTests/platform/ios-sim/Skipped:743 > -# FIXME: <rdar://problem/8987731> iOS: Update/unskip SVG tests after turning on ENABLE_FILTERS > +# FIXME: <rdar://problem/8987731> iOS: Update/unskip SVG tests I don't think if we should change this comment, but iOS maintainers should unskip these tests if they are passing.
Created attachment 237775 [details] Patch
Comment on attachment 237775 [details] Patch Clearing flags on attachment: 237775 Committed r173397: <http://trac.webkit.org/changeset/173397>
All reviewed patches have been landed. Closing bug.