Bug 136567 - Enable GenGC on ARM Traditional
Summary: Enable GenGC on ARM Traditional
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-05 01:43 PDT by Dániel Bátyai
Modified: 2014-09-05 03:25 PDT (History)
5 users (show)

See Also:


Attachments
Patch (990 bytes, patch)
2014-09-05 01:44 PDT, Dániel Bátyai
ossy: review-
Details | Formatted Diff | Diff
Patch (971 bytes, patch)
2014-09-05 01:54 PDT, Dániel Bátyai
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dániel Bátyai 2014-09-05 01:43:35 PDT
Enable Generational GC on ARM Traditional
Comment 1 Dániel Bátyai 2014-09-05 01:44:42 PDT
Created attachment 237679 [details]
Patch
Comment 2 Csaba Osztrogonác 2014-09-05 01:51:32 PDT
Comment on attachment 237679 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237679&action=review

> Source/WTF/wtf/Platform.h:761
> -#if CPU(X86_64) || CPU(X86) || CPU(ARM_THUMB2) || CPU(ARM64)
> +#if CPU(X86_64) || CPU(X86) || CPU(ARM_THUMB2) || CPU(ARM64) || CPU(ARM)

CPU(ARM_THUMB2) is a subset of CPU(ARM), so I prefer
simple use CPU(ARM) instead of CPU(ARM_THUMB2):

#if CPU(X86_64) || CPU(X86) || CPU(ARM) || CPU(ARM64)
Comment 3 Dániel Bátyai 2014-09-05 01:54:33 PDT
Created attachment 237680 [details]
Patch
Comment 4 WebKit Commit Bot 2014-09-05 03:25:26 PDT
Comment on attachment 237680 [details]
Patch

Clearing flags on attachment: 237680

Committed r173310: <http://trac.webkit.org/changeset/173310>
Comment 5 WebKit Commit Bot 2014-09-05 03:25:29 PDT
All reviewed patches have been landed.  Closing bug.