Bug 136552 - Fix FIXME's in JSTrackCustom now that AudioTrack and VideoTrack exist.
Summary: Fix FIXME's in JSTrackCustom now that AudioTrack and VideoTrack exist.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brendan Long
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-04 15:45 PDT by Brendan Long
Modified: 2014-09-11 08:04 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.58 KB, patch)
2014-09-04 15:47 PDT, Brendan Long 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brendan Long 2014-09-04 15:45:51 PDT 
Fix FIXME's in JSTrackCustom not that AudioTrack and VideoTrack exist.
Comment 1 Brendan Long 2014-09-04 15:47:18 PDT 
Created attachment 237652 [details]
Patch
Comment 2 Brendan Long 2014-09-04 15:48:08 PDT 
I saw this FIXME while I was working on another patch. I'm not really sure how this code is used though. Is there some way I could test this?
Comment 3 Eric Carlson 2014-09-05 09:52:56 PDT 
(In reply to comment #2)
> I saw this FIXME while I was working on another patch. I'm not really sure how this code is used though. Is there some way I could test this?

I think toTrack() is only used by JSDictionary::convertValue() currently, and I believe that is only used when MediaStream is enabled so you can't test it at the moment.
Comment 4 Eric Carlson 2014-09-05 09:58:58 PDT 
(In reply to comment #3)
> (In reply to comment #2)
> > I saw this FIXME while I was working on another patch. I'm not really sure how this code is used though. Is there some way I could test this?
> 
> I think toTrack() is only used by JSDictionary::convertValue() currently, and I believe that is only used when MediaStream is enabled so you can't test it at the moment.

Scratch that, it can also be used for a TrackEvent. But I am still not sure how you would test it.
Comment 5 Brendan Long 2014-09-10 15:32:32 PDT 
Sorry, got distracted by some other stuff. Do you think we should apply this fix, or should we wait until we have some way to test it?
Comment 6 Eric Carlson 2014-09-10 16:40:56 PDT 
(In reply to comment #5)
> Sorry, got distracted by some other stuff. Do you think we should apply this fix, or should we wait until we have some way to test it?

Why don't you land it, the new code is obviously better than what we have now.
Comment 7 WebKit Commit Bot 2014-09-11 08:03:56 PDT 
Comment on attachment 237652 [details]
Patch

Clearing flags on attachment: 237652

Committed r173513: <http://trac.webkit.org/changeset/173513>
Comment 8 WebKit Commit Bot 2014-09-11 08:04:00 PDT 
All reviewed patches have been landed.  Closing bug.