Bug 136543 - Use WTFString::split(char) in more places
Summary: Use WTFString::split(char) in more places
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-04 12:57 PDT by Joseph Pecoraro
Modified: 2014-09-05 21:58 PDT (History)
9 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (9.66 KB, patch)
2014-09-04 12:58 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (9.62 KB, patch)
2014-09-04 13:41 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-09-04 12:57:00 PDT
Instead of WTFString::split(String&) use WTFString::split(char) in places where we would be converting a string literal to a WTFString unnecessarily.
Comment 1 Joseph Pecoraro 2014-09-04 12:58:19 PDT
Created attachment 237642 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2014-09-04 12:59:32 PDT
Attachment 237642 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Joseph Pecoraro 2014-09-04 13:41:04 PDT
Created attachment 237645 [details]
[PATCH] Proposed Fix
Comment 4 WebKit Commit Bot 2014-09-05 21:58:47 PDT
Comment on attachment 237645 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 237645

Committed r173350: <http://trac.webkit.org/changeset/173350>
Comment 5 WebKit Commit Bot 2014-09-05 21:58:51 PDT
All reviewed patches have been landed.  Closing bug.