Bug 13654 - REGRESSION: Fieldset stretches too much because minwidth is wrong.
Summary: REGRESSION: Fieldset stretches too much because minwidth is wrong.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Dave Hyatt
Keywords: InRadar
Depends on:
Reported: 2007-05-10 04:37 PDT by Dave Hyatt
Modified: 2007-05-10 05:30 PDT (History)
0 users

See Also:

Reduction (1.47 KB, text/html)
2007-05-10 04:37 PDT, Dave Hyatt
no flags Details
This fixes it. (1.04 KB, patch)
2007-05-10 05:08 PDT, Dave Hyatt
no flags Details | Formatted Diff | Diff
Better patch. (1.04 KB, patch)
2007-05-10 05:20 PDT, Dave Hyatt
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2007-05-10 04:37:03 PDT
In the attached test case, the fieldset has a minwidth that is bigger than other browsers.  Clear whitespace breaking opportunities exist, and yet they are somehow not being factored into the minwidth.

This is a regression caused by


although I think it just exposed a min width bug.
Comment 1 Dave Hyatt 2007-05-10 04:37:52 PDT
Created attachment 14457 [details]

Comment 2 Dave Hyatt 2007-05-10 04:38:30 PDT
Comment 3 Dave Hyatt 2007-05-10 05:08:28 PDT
Created attachment 14459 [details]
This fixes it.

Any text run that gets thoroughly ignored but that contains only stripped out whitespace will have beginWS and endWS set to true.  Combine that with autoWrap and you know when a break opportunity exists.
Comment 4 Dave Hyatt 2007-05-10 05:20:43 PDT
Created attachment 14460 [details]
Better patch.

After conversation with mitz on IRC, new patch.
Comment 5 mitz 2007-05-10 05:22:01 PDT
Comment on attachment 14460 [details]
Better patch.

r=me. fix indentation of the first 'if'!
Comment 6 Dave Hyatt 2007-05-10 05:30:19 PDT
Fixed in r21365.