Bug 136539 - REGRESSION: Dashboard metrics page aggregation counts performance bots
Summary: REGRESSION: Dashboard metrics page aggregation counts performance bots
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-04 11:54 PDT by Alexey Proskuryakov
Modified: 2014-09-04 13:01 PDT (History)
3 users (show)

See Also:

Attachments
proposed fix (1.47 KB, patch)
2014-09-04 11:56 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-09-04 11:54:12 PDT 
The dashboard metrics page doesn't show performance bots on the grid, so it's unexpected that their results are taken into account at all.

Furthermore, waiting for performance bots to cycle is not generally considered as part of due diligence after landing a patch, so performance bots should not be included in the elapsed time anyway. It's arguable whether they should be included in red/green time.
Comment 1 Alexey Proskuryakov 2014-09-04 11:56:47 PDT 
Created attachment 237637 [details]
proposed fix
Comment 2 WebKit Commit Bot 2014-09-04 13:01:49 PDT 
Comment on attachment 237637 [details]
proposed fix

Clearing flags on attachment: 237637

Committed r173273: <http://trac.webkit.org/changeset/173273>
Comment 3 WebKit Commit Bot 2014-09-04 13:01:51 PDT 
All reviewed patches have been landed.  Closing bug.