Bug 136535 - Allow pages with unload handlers in the page cache
Summary: Allow pages with unload handlers in the page cache
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-09-04 10:44 PDT by Brady Eidson
Modified: 2014-09-05 15:11 PDT (History)
1 user (show)

See Also:

Attachments
Patch v1 (4.60 KB, patch)
2014-09-04 14:24 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-09-04 10:44:16 PDT 
Allow pages with unload handlers in the page cache.

It's 2014.  unload events served their purpose a decade ago, but we've had pagehide for years to overcome unload's shortcomings.

Let's stop letting the mere existence of an unload handler kill an import performance enhancement, and willfully break unload semantics instead.

<rdar://problem/11084669>
Comment 1 Brady Eidson 2014-09-04 14:24:12 PDT 
Created attachment 237647 [details]
Patch v1 

Ran tests locally, but not confident in my findings - This is for EWS
Comment 2 Brady Eidson 2014-09-05 14:30:22 PDT 
This should be fine, let's review it and land it.
Comment 3 WebKit Commit Bot 2014-09-05 15:11:27 PDT 
Comment on attachment 237647 [details]
Patch v1 

Clearing flags on attachment: 237647

Committed r173336: <http://trac.webkit.org/changeset/173336>
Comment 4 WebKit Commit Bot 2014-09-05 15:11:29 PDT 
All reviewed patches have been landed.  Closing bug.