Bug 136529 - Remove CSS_FILTERS flag
Summary: Remove CSS_FILTERS flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-04 04:41 PDT by Éva Balázsfalvi
Modified: 2014-09-05 00:55 PDT (History)
4 users (show)

See Also:

Attachments
Patch (209.25 KB, patch)
2014-09-04 05:07 PDT, Éva Balázsfalvi 		no flags Details | Formatted Diff | Diff
Patch (209.95 KB, patch)
2014-09-04 06:15 PDT, Éva Balázsfalvi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Éva Balázsfalvi 2014-09-04 04:41:15 PDT 
CSS_FILTERS flag is enabled on all ports.
Comment 1 Éva Balázsfalvi 2014-09-04 05:07:11 PDT 
Created attachment 237621 [details]
Patch
Comment 2 Csaba Osztrogonác 2014-09-04 05:59:13 PDT 
Comment on attachment 237621 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237621&action=review

> Source/WebCore/WebCore.exp.in:-3021
> -#if ENABLE(CSS_FILTERS)
>  __ZN7WebCore16FilterOperationsaSERKS0_
> -#endif

We should move it to the unconditional list.

> Source/WebCore/bindings/js/JSCSSValueCustom.cpp:-44
> -#if ENABLE(CSS_FILTERS)
>  #include "JSWebKitCSSFilterValue.h"
>  #include "WebKitCSSFilterValue.h"
> -#endif

alphabetical order

> Source/WebCore/bindings/objc/DOMCSS.mm:-57
> -#if ENABLE(CSS_FILTERS)
>  #import "DOMWebKitCSSFilterValue.h"
> -#endif

ditto

> Source/WebCore/css/CSSFilterImageValue.cpp:-31
> -
> -#if ENABLE(CSS_FILTERS)
> -

We need an empty line after #include "CSSFilterImageValue.h"
Comment 3 Éva Balázsfalvi 2014-09-04 06:15:11 PDT 
Created attachment 237622 [details]
Patch
Comment 4 Csaba Osztrogonác 2014-09-04 06:49:38 PDT 
discussion about it on webkit-dev without any objection:
https://lists.webkit.org/pipermail/webkit-dev/2014-May/026553.html

We could remove FILTERS too in the near future. 
Are you going to prepare a patch for it too?
Comment 5 Dirk Schulze 2014-09-04 11:08:14 PDT 
Comment on attachment 237622 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2014-09-04 11:43:51 PDT 
Comment on attachment 237622 [details]
Patch

Clearing flags on attachment: 237622

Committed r173268: <http://trac.webkit.org/changeset/173268>
Comment 7 WebKit Commit Bot 2014-09-04 11:43:54 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Éva Balázsfalvi 2014-09-05 00:55:34 PDT 
(In reply to comment #4)
> discussion about it on webkit-dev without any objection:
> https://lists.webkit.org/pipermail/webkit-dev/2014-May/026553.html
> 
> We could remove FILTERS too in the near future. 
> Are you going to prepare a patch for it too?

Yes, I'm working on it already.