RESOLVED FIXED 136514
Initial letters should clear one another 
https://bugs.webkit.org/show_bug.cgi?id=136514
Summary Initial letters should clear one another
Dave Hyatt
Reported 2014-09-03 16:23:36 PDT
Initial letters should clear one another so that short paragraphs don't result in first letters getting jumbled up.
Attachments
Patch (61.32 KB, patch)
2014-09-03 16:27 PDT, Dave Hyatt 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2014-09-03 16:27:02 PDT
Created attachment 237599 [details] Patch
Simon Fraser (smfr)
Comment 2 2014-09-03 16:29:40 PDT
Comment on attachment 237599 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237599&action=review > Source/WebCore/rendering/RenderBlockFlow.cpp:2304 > + bool isInitialLetter = childBox.style().styleType() == FIRST_LETTER && childBox.style().initialLetterDrop() > 0; Seems like this could be an inline function on RenderStyle. > Source/WebCore/rendering/RenderBlockFlow.cpp:2576 > + const FloatingObjectSet& floatingObjectSet = m_floatingObjects->set(); auto? > Source/WebCore/rendering/RenderBlockFlow.cpp:2580 > + if (floatingObject->isPlaced() && floatingObject->renderer().style().styleType() == FIRST_LETTER && floatingObject->renderer().style().initialLetterDrop() > 0) Then you could say floatingObject->renderer().style().hasInitialLetter() here.
Dave Hyatt
Comment 3 2014-09-04 13:58:56 PDT
Not going to add the method to RenderStyle, but only because next patch will add support for initial-letter on things other than first letters, and at that point just checking the property itself (without checking first letter any longer) will be sufficient.
Radar WebKit Bug Importer
Comment 4 2014-11-11 09:52:08 PST
<rdar://problem/18941425>
Jon Lee
Comment 5 2014-11-11 09:52:30 PST
Changelist 173281
Note You need to log in before you can comment on or make changes to this bug.