Bug 136498 - Delete class SavedDrawingStateForMask
Summary: Delete class SavedDrawingStateForMask
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-03 14:11 PDT by Myles C. Maxfield
Modified: 2014-09-10 17:50 PDT (History)
14 users (show)

See Also:

Attachments
Patch (19.65 KB, patch)
2014-09-09 14:43 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (19.86 KB, patch)
2014-09-09 16:03 PDT, Myles C. Maxfield 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2014-09-03 14:11:23 PDT 
It is unnecessary.
Comment 1 Myles C. Maxfield 2014-09-09 14:43:18 PDT 
Created attachment 237858 [details]
Patch
Comment 2 WebKit Commit Bot 2014-09-09 14:44:59 PDT 
Attachment 237858 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/TextPainter.cpp:38:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Myles C. Maxfield 2014-09-09 16:03:17 PDT 
Created attachment 237868 [details]
Patch
Comment 4 WebKit Commit Bot 2014-09-09 16:06:07 PDT 
Attachment 237868 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/TextPainter.cpp:38:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Myles C. Maxfield 2014-09-09 17:06:31 PDT 
Style error is a false positive.
Comment 6 Darin Adler 2014-09-10 08:34:53 PDT 
Comment on attachment 237868 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237868&action=review

> Source/WebCore/rendering/TextPainter.cpp:139
> +            TextRun& emphasisMarkTextRun = m_combinedText ? static_cast<TextRun&>(objectReplacementCharacterTextRun) : m_textRun;

Instead of:

    static_cast<TextRun&>(objectReplacementCharacterTextRun)

Should use:

    objectReplacementCharacterTextRun.get()
Comment 7 Myles C. Maxfield 2014-09-10 17:16:16 PDT 
Comment on attachment 237868 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237868&action=review

>> Source/WebCore/rendering/TextPainter.cpp:139
>> +            TextRun& emphasisMarkTextRun = m_combinedText ? static_cast<TextRun&>(objectReplacementCharacterTextRun) : m_textRun;
> 
> Instead of:
> 
>     static_cast<TextRun&>(objectReplacementCharacterTextRun)
> 
> Should use:
> 
>     objectReplacementCharacterTextRun.get()

Done.
Comment 8 Myles C. Maxfield 2014-09-10 17:50:38 PDT 
https://trac.webkit.org/r173502