Bug 136491 - Get rid of HIGH_DPI_CANVAS leftovers
Summary: Get rid of HIGH_DPI_CANVAS leftovers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-03 11:56 PDT by mitz
Modified: 2014-09-04 01:28 PDT (History)
12 users (show)

See Also:

Attachments
I. Remove EANBLE_HIGH_DPI_CANVAS (33.47 KB, patch)
2014-09-03 12:00 PDT, mitz 		benjamin: review+
Details | Formatted Diff | Diff
II. Remove HTMLCanvasElement::deviceScaleFactor() (8.84 KB, patch)
2014-09-03 13:35 PDT, mitz 		benjamin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-09-03 11:56:22 PDT 
The HIGH_DPI_CANVAS feature is not enabled in any configuration.
Comment 1 mitz 2014-09-03 12:00:45 PDT 
Created attachment 237567 [details]
I. Remove EANBLE_HIGH_DPI_CANVAS
Comment 2 Benjamin Poulain 2014-09-03 12:16:24 PDT 
Comment on attachment 237567 [details]
I. Remove EANBLE_HIGH_DPI_CANVAS

View in context: https://bugs.webkit.org/attachment.cgi?id=237567&action=review

> Source/WebCore/html/HTMLCanvasElement.cpp:351
>  float HTMLCanvasElement::targetDeviceScaleFactor() const

Can't you remove all the "target device scale factor" stuff from canvas?
Comment 3 mitz 2014-09-03 12:16:59 PDT 
(In reply to comment #2)
> (From update of attachment 237567 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=237567&action=review
> 
> > Source/WebCore/html/HTMLCanvasElement.cpp:351
> >  float HTMLCanvasElement::targetDeviceScaleFactor() const
> 
> Can't you remove all the "target device scale factor" stuff from canvas?

I can.
Comment 4 mitz 2014-09-03 12:18:25 PDT 
Committed attachment 237567 [details] as <http://trac.webkit.org/r173215>.
Comment 5 mitz 2014-09-03 13:35:39 PDT 
Created attachment 237577 [details]
II. Remove HTMLCanvasElement::deviceScaleFactor()
Comment 6 Benjamin Poulain 2014-09-03 14:28:46 PDT 
Comment on attachment 237577 [details]
II. Remove HTMLCanvasElement::deviceScaleFactor()

Neat!
Comment 7 mitz 2014-09-04 01:28:57 PDT 
Committed attachment 237577 [details] as <http://trac.webkit.org/r173256>.