Bug 136490 - CallEdgeProfile::visitWeak() should gracefully handle the case where primaryCallee duplicates an entry in otherCallees
Summary: CallEdgeProfile::visitWeak() should gracefully handle the case where primaryC...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-03 11:48 PDT by Filip Pizlo
Modified: 2014-09-03 11:58 PDT (History)
8 users (show)

See Also:

Attachments
the patch (2.02 KB, patch)
2014-09-03 11:49 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-09-03 11:48:38 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2014-09-03 11:49:26 PDT 
Created attachment 237566 [details]
the patch
Comment 2 Geoffrey Garen 2014-09-03 11:52:02 PDT 
Comment on attachment 237566 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237566&action=review

r=me

> Source/JavaScriptCore/bytecode/CallEdgeProfile.cpp:143
> +            // the primary culd duplicate an entry in otherCallees, which means that even though we

"could"
Comment 3 Filip Pizlo 2014-09-03 11:58:44 PDT 
Landed in http://trac.webkit.org/changeset/173214