Bug 136486 - [Win] Revise test environment for Windows build
Summary: [Win] Revise test environment for Windows build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
: 125180 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-09-03 10:37 PDT by Brent Fulgham
Modified: 2014-09-03 13:12 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.37 KB, patch)
2014-09-03 11:09 PDT, Brent Fulgham 		ddkilzer: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-09-03 10:37:23 PDT 
The Windows build and test system has some cruft that needs to be cleaned up:
1. DRT and friends know how to find 64-bit runtimes, so the special cases in webkitdirs.pm should be removed.
2. We don't need to look for Safari.exe on Windows to run tests, and shouldn't complain if we don't find it.
3. Where possible, we should use File::Spec for file handling so that we can be agnostic about whether the tests are being run under Cygwin or not.
Comment 1 Brent Fulgham 2014-09-03 11:09:38 PDT 
Created attachment 237562 [details]
Patch
Comment 2 Brent Fulgham 2014-09-03 11:15:37 PDT 
*** Bug 125180 has been marked as a duplicate of this bug. ***
Comment 3 Brent Fulgham 2014-09-03 13:01:15 PDT 
I didn't actually make any File::Spec changes here. That will be coming in a separate change.
Comment 4 David Kilzer (:ddkilzer) 2014-09-03 13:05:58 PDT 
Comment on attachment 237562 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237562&action=review

r=me

> Tools/Scripts/webkitdirs.pm:765
> +    die "Safari Path is only relevant on Mac platform\n" unless isAppleMacWebKit();

Nit:  Lowercase "Path"?  Maybe say instead:

    die "Safari path is only relevant on Apple Mac platform\n" unless isAppleMacWebKit();

> Tools/Scripts/webkitdirs.pm:784
> +    die "Safari Path is only relevant on Mac platform\n" unless isAppleMacWebKit();

Same:

    die "Safari path is only relevant on Apple Mac platform\n" unless isAppleMacWebKit();
Comment 5 Brent Fulgham 2014-09-03 13:12:43 PDT 
Committed r173219: <http://trac.webkit.org/changeset/173219>