Bug 136481 - [WinCairo] jsc.exe won't run.
Summary: [WinCairo] jsc.exe won't run.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-03 06:01 PDT by peavo
Modified: 2014-09-05 13:02 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.22 KB, patch)
2014-09-03 06:05 PDT, peavo
no flags Details | Formatted Diff | Diff
Patch (10.48 KB, patch)
2014-09-03 13:12 PDT, peavo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2014-09-03 06:01:10 PDT
I get the message "Failed to determine path to AAS directory". We need to define WIN_CAIRO.
Comment 1 peavo 2014-09-03 06:05:54 PDT
Created attachment 237559 [details]
Patch
Comment 2 Alex Christensen 2014-09-03 07:23:55 PDT
Comment on attachment 237559 [details]
Patch

Let's do the same thing as WinLauncher and DumpRenderTree and import DLLLauncherWinCairo.props instead.
Comment 3 peavo 2014-09-03 13:12:11 PDT
Created attachment 237575 [details]
Patch
Comment 4 peavo 2014-09-03 13:13:51 PDT
(In reply to comment #2)
> (From update of attachment 237559 [details])
> Let's do the same thing as WinLauncher and DumpRenderTree and import DLLLauncherWinCairo.props instead.

Thanks for reviewing, updated patch accordingly :)
I made a copy of DLLLauncherWinCairo.props to avoid cross-module dependencies.
Comment 5 Alex Christensen 2014-09-05 12:05:19 PDT
Comment on attachment 237575 [details]
Patch

There is already a copy of DLLLauncherMain.cpp from Tools/win/DLLLauncher to Source/JavaScriptCore/JavaScriptCore.vcxproj/jsc.  As much as I don't like duplicate code, this follows that pattern.
Comment 6 WebKit Commit Bot 2014-09-05 12:42:17 PDT
Comment on attachment 237575 [details]
Patch

Clearing flags on attachment: 237575

Committed r173327: <http://trac.webkit.org/changeset/173327>
Comment 7 WebKit Commit Bot 2014-09-05 12:42:20 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 peavo 2014-09-05 13:02:59 PDT
(In reply to comment #5)
> (From update of attachment 237575 [details])
> There is already a copy of DLLLauncherMain.cpp from Tools/win/DLLLauncher to Source/JavaScriptCore/JavaScriptCore.vcxproj/jsc.  As much as I don't like duplicate code, this follows that pattern.

Thanks for reviewing :)