WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
136472
Fix style invalidation of elements with multiple siblings dependencies
https://bugs.webkit.org/show_bug.cgi?id=136472
Summary
Fix style invalidation of elements with multiple siblings dependencies
Benjamin Poulain
Reported
2014-09-02 18:23:14 PDT
Fix style invalidation of elements with multiple siblings dependencies
Attachments
Patch
(183.64 KB, patch)
2014-09-02 18:55 PDT
,
Benjamin Poulain
kling
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Benjamin Poulain
Comment 1
2014-09-02 18:55:28 PDT
Created
attachment 237542
[details]
Patch
Andreas Kling
Comment 2
2014-09-03 12:44:50 PDT
Comment on
attachment 237542
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=237542&action=review
r=me
> Source/WebCore/html/HTMLElement.h:91 > - bool isHTMLUnknownElement() const { return getFlag(IsHTMLUnknownElementFlag); } > + virtual bool isHTMLUnknownElement() const { return false; }
RIP my micro-optimization :|
> Source/WebCore/html/HTMLUnknownElement.h:44 > + virtual bool isHTMLUnknownElement() const { return true; }
Missing override.
Benjamin Poulain
Comment 3
2014-09-03 14:30:44 PDT
Committed
r173229
: <
http://trac.webkit.org/changeset/173229
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug