Bug 136472 - Fix style invalidation of elements with multiple siblings dependencies
Summary: Fix style invalidation of elements with multiple siblings dependencies
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-02 18:23 PDT by Benjamin Poulain
Modified: 2014-09-03 14:30 PDT (History)
2 users (show)

See Also:

Attachments
Patch (183.64 KB, patch)
2014-09-02 18:55 PDT, Benjamin Poulain 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-09-02 18:23:14 PDT 
Fix style invalidation of elements with multiple siblings dependencies
Comment 1 Benjamin Poulain 2014-09-02 18:55:28 PDT 
Created attachment 237542 [details]
Patch
Comment 2 Andreas Kling 2014-09-03 12:44:50 PDT 
Comment on attachment 237542 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237542&action=review

r=me

> Source/WebCore/html/HTMLElement.h:91
> -    bool isHTMLUnknownElement() const { return getFlag(IsHTMLUnknownElementFlag); }
> +    virtual bool isHTMLUnknownElement() const { return false; }

RIP my micro-optimization :|

> Source/WebCore/html/HTMLUnknownElement.h:44
> +    virtual bool isHTMLUnknownElement() const { return true; }

Missing override.
Comment 3 Benjamin Poulain 2014-09-03 14:30:44 PDT 
Committed r173229: <http://trac.webkit.org/changeset/173229>