Bug 136470 - Use StringBuilder append(char) and appendLiteral in more places
Summary: Use StringBuilder append(char) and appendLiteral in more places
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-02 16:07 PDT by Joseph Pecoraro
Modified: 2014-09-03 11:43 PDT (History)
2 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (32.99 KB, patch)
2014-09-02 16:09 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-09-02 16:07:27 PDT
Use StringBuilder::append(char) and StringBuilder::appendLiteral in more places.

I checked `binaryinfo $build/Release/WebCore.framework/WebCore` before and after my change and it was the same:

> TEXT SIZE  DATA SIZE  OBJC SIZE  OTHR SIZE  EXPORTS  LINKAGE  NAMESPACE  PREBOUND  BINARY
> =========  =========  =========  =========  =======  =======  =========  ========  ==========
>  16500 KB    1852 KB       0 KB   18192 KB     2921  -n TOO MUCH
Comment 1 Joseph Pecoraro 2014-09-02 16:09:31 PDT
Created attachment 237525 [details]
[PATCH] Proposed Fix
Comment 2 Andreas Kling 2014-09-03 10:35:19 PDT
Comment on attachment 237525 [details]
[PATCH] Proposed Fix

r=me
Comment 3 WebKit Commit Bot 2014-09-03 11:43:06 PDT
Comment on attachment 237525 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 237525

Committed r173212: <http://trac.webkit.org/changeset/173212>
Comment 4 WebKit Commit Bot 2014-09-03 11:43:09 PDT
All reviewed patches have been landed.  Closing bug.