RESOLVED FIXED 136468
MallocBench should have a stress test for correctness 
https://bugs.webkit.org/show_bug.cgi?id=136468
Summary MallocBench should have a stress test for correctness
Geoffrey Garen
Reported 2014-09-02 15:57:55 PDT
MallocBench should have a stress test for correctness
Attachments
Patch (12.27 KB, patch)
2014-09-02 16:03 PDT, Geoffrey Garen 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2014-09-02 16:03:29 PDT
Created attachment 237524 [details] Patch
WebKit Commit Bot
Comment 2 2014-09-02 16:06:10 PDT
Attachment 237524 [details] did not pass style-queue: ERROR: PerformanceTests/MallocBench/MallocBench/stress.h:29: benchmark_stress is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: PerformanceTests/MallocBench/MallocBench/stress.cpp:26: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: PerformanceTests/MallocBench/MallocBench/stress.cpp:28: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: PerformanceTests/MallocBench/MallocBench/stress.cpp:36: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: PerformanceTests/MallocBench/MallocBench/stress.cpp:70: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: PerformanceTests/MallocBench/MallocBench/stress.cpp:78: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: PerformanceTests/MallocBench/MallocBench/stress.cpp:103: benchmark_stress is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 7 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3 2014-09-03 10:27:44 PDT
Comment on attachment 237524 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237524&action=review r=me > PerformanceTests/ChangeLog:21 > + (benchmark_stress): Usually, we random(0). Surprisingly, though, only > + random(1) reproduces the bug I was looking for. This feels a bit sketchy, but it's better than not having a test at all.
Geoffrey Garen
Comment 4 2014-09-03 14:00:12 PDT
Committed r173223: <http://trac.webkit.org/changeset/173223>
Note You need to log in before you can comment on or make changes to this bug.