Bug 136463 - Use references in public EventSender functions
Summary: Use references in public EventSender functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-02 13:51 PDT by Myles C. Maxfield
Modified: 2014-09-03 13:47 PDT (History)
11 users (show)

See Also:

Attachments
Patch (11.13 KB, patch)
2014-09-02 13:52 PDT, Myles C. Maxfield 		dbates: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2014-09-02 13:51:11 PDT 
Use references in public EventSender functions
Comment 1 Myles C. Maxfield 2014-09-02 13:52:47 PDT 
Created attachment 237512 [details]
Patch
Comment 2 Daniel Bates 2014-09-02 14:20:51 PDT 
Comment on attachment 237512 [details]
Patch

r=me
Comment 3 Daniel Bates 2014-09-02 14:22:46 PDT 
Comment on attachment 237512 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237512&action=review

> Source/WebCore/dom/EventSender.h:78
>      size_t size = m_dispatchSoonList.size();
>      for (size_t i = 0; i < size; ++i) {

Nit: We should update this code to use a C++11 range-for loop.

> Source/WebCore/dom/EventSender.h:103
>      size_t size = m_dispatchingList.size();
>      for (size_t i = 0; i < size; ++i) {

Ditto.
Comment 4 Myles C. Maxfield 2014-09-03 13:47:04 PDT 
http://trac.webkit.org/changeset/173190