WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
136463
Use references in public EventSender functions
https://bugs.webkit.org/show_bug.cgi?id=136463
Summary
Use references in public EventSender functions
Myles C. Maxfield
Reported
2014-09-02 13:51:11 PDT
Use references in public EventSender functions
Attachments
Patch
(11.13 KB, patch)
2014-09-02 13:52 PDT
,
Myles C. Maxfield
dbates
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1
2014-09-02 13:52:47 PDT
Created
attachment 237512
[details]
Patch
Daniel Bates
Comment 2
2014-09-02 14:20:51 PDT
Comment on
attachment 237512
[details]
Patch r=me
Daniel Bates
Comment 3
2014-09-02 14:22:46 PDT
Comment on
attachment 237512
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=237512&action=review
> Source/WebCore/dom/EventSender.h:78 > size_t size = m_dispatchSoonList.size(); > for (size_t i = 0; i < size; ++i) {
Nit: We should update this code to use a C++11 range-for loop.
> Source/WebCore/dom/EventSender.h:103 > size_t size = m_dispatchingList.size(); > for (size_t i = 0; i < size; ++i) {
Ditto.
Myles C. Maxfield
Comment 4
2014-09-03 13:47:04 PDT
http://trac.webkit.org/changeset/173190
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug