Bug 136462 - Web Inspector: remove ProfilerAgent and legacy profiler files in the frontend
Summary: Web Inspector: remove ProfilerAgent and legacy profiler files in the frontend
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brian Burg
URL:
Keywords: InRadar
Depends on:
Blocks: 136380
  Show dependency tree / graph
 
Reported: 2014-09-02 13:47 PDT by Brian Burg
Modified: 2014-09-02 20:17 PDT (History)
9 users (show)

See Also:

Attachments
Proposed fix (182.15 KB, patch)
2014-09-02 16:34 PDT, Brian Burg 		timothy: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-09-02 13:47:11 PDT 
They are not used anywhere.
Comment 1 Radar WebKit Bug Importer 2014-09-02 13:47:44 PDT 
<rdar://problem/18204711>
Comment 2 Brian Burg 2014-09-02 16:34:40 PDT 
Created attachment 237530 [details]
Proposed fix
Comment 3 Timothy Hatcher 2014-09-02 16:51:31 PDT 
Comment on attachment 237530 [details]
Proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=237530&action=review

> Source/WebCore/inspector/protocol/Timeline.json:50
> +                { "name": "idleTime", "type": "number", "optional": true }

Didn't you remove this in another patch?
Comment 4 Brian Burg 2014-09-02 17:04:30 PDT 
(In reply to comment #3)
> (From update of attachment 237530 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=237530&action=review
> 
> > Source/WebCore/inspector/protocol/Timeline.json:50
> > +                { "name": "idleTime", "type": "number", "optional": true }
> 
> Didn't you remove this in another patch?

Yes, going to land this one first though once EWS is done.
Comment 5 Brian Burg 2014-09-02 20:17:58 PDT 
Committed r173198: <http://trac.webkit.org/changeset/173198>