Bug 136461 - Move computeInlinePreferredLogicalWidths() from RenderBlock to RenderBlockFlow
Summary: Move computeInlinePreferredLogicalWidths() from RenderBlock to RenderBlockFlow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-02 13:38 PDT by zalan
Modified: 2014-09-05 07:18 PDT (History)
6 users (show)

See Also:


Attachments
Patch (41.67 KB, patch)
2014-09-02 13:50 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (41.62 KB, patch)
2014-09-04 09:17 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-09-02 13:38:28 PDT
and make it const function.
Comment 1 zalan 2014-09-02 13:50:56 PDT
Created attachment 237511 [details]
Patch
Comment 2 WebKit Commit Bot 2014-09-02 13:52:41 PDT
Attachment 237511 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:3869:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:3870:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:3873:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:3874:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:4088:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:4089:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 6 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Darin Adler 2014-09-04 01:30:09 PDT
Comment on attachment 237511 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237511&action=review

> Source/WebCore/rendering/RenderBlockFlow.cpp:3794
> +    const RenderObject* parent;

Should be RenderBlockFlow&, not RenderObject*.

> Source/WebCore/rendering/RenderBlockFlow.cpp:3799
> +    InlineMinMaxIterator(const RenderObject* p)

Should be RenderBlockFlow&, not RenderObject*.
Comment 4 zalan 2014-09-04 09:17:55 PDT
Created attachment 237628 [details]
Patch
Comment 5 zalan 2014-09-04 09:18:28 PDT
(In reply to comment #3)
> (From update of attachment 237511 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=237511&action=review
> 
> > Source/WebCore/rendering/RenderBlockFlow.cpp:3794
> > +    const RenderObject* parent;
> 
> Should be RenderBlockFlow&, not RenderObject*.
Done.

> 
> > Source/WebCore/rendering/RenderBlockFlow.cpp:3799
> > +    InlineMinMaxIterator(const RenderObject* p)
> 
> Should be RenderBlockFlow&, not RenderObject*.
Done. Thanks!
Comment 6 WebKit Commit Bot 2014-09-04 09:19:48 PDT
Attachment 237628 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:3900:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:3901:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:3904:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:3905:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:4119:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:4120:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 6 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 WebKit Commit Bot 2014-09-05 07:18:22 PDT
Comment on attachment 237628 [details]
Patch

Clearing flags on attachment: 237628

Committed r173311: <http://trac.webkit.org/changeset/173311>
Comment 8 WebKit Commit Bot 2014-09-05 07:18:26 PDT
All reviewed patches have been landed.  Closing bug.