and make it const function.
Created attachment 237511 [details] Patch
Attachment 237511 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:3869: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:3870: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:3873: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:3874: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:4088: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:4089: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 6 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 237511 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237511&action=review > Source/WebCore/rendering/RenderBlockFlow.cpp:3794 > + const RenderObject* parent; Should be RenderBlockFlow&, not RenderObject*. > Source/WebCore/rendering/RenderBlockFlow.cpp:3799 > + InlineMinMaxIterator(const RenderObject* p) Should be RenderBlockFlow&, not RenderObject*.
Created attachment 237628 [details] Patch
(In reply to comment #3) > (From update of attachment 237511 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=237511&action=review > > > Source/WebCore/rendering/RenderBlockFlow.cpp:3794 > > + const RenderObject* parent; > > Should be RenderBlockFlow&, not RenderObject*. Done. > > > Source/WebCore/rendering/RenderBlockFlow.cpp:3799 > > + InlineMinMaxIterator(const RenderObject* p) > > Should be RenderBlockFlow&, not RenderObject*. Done. Thanks!
Attachment 237628 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:3900: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:3901: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:3904: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:3905: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:4119: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:4120: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 6 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 237628 [details] Patch Clearing flags on attachment: 237628 Committed r173311: <http://trac.webkit.org/changeset/173311>
All reviewed patches have been landed. Closing bug.