Bug 136458 - Optimize own property GetByVals with rope string subscripts.
Summary: Optimize own property GetByVals with rope string subscripts.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: Performance
Depends on:
Blocks:
 
Reported: 2014-09-02 10:57 PDT by Andreas Kling
Modified: 2014-09-02 15:30 PDT (History)
2 users (show)

See Also:

Attachments
Patch (12.11 KB, patch)
2014-09-02 10:58 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-09-02 10:57:44 PDT 
Patch forthcoming.
Comment 1 Andreas Kling 2014-09-02 10:58:36 PDT 
Created attachment 237505 [details]
Patch
Comment 2 Geoffrey Garen 2014-09-02 12:42:46 PDT 
Comment on attachment 237505 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237505&action=review

r=me

> Source/JavaScriptCore/dfg/DFGOperations.cpp:300
> +                if (AtomicStringImpl* existingAtomicString = asString(property)->toExistingAtomicString(exec)) {

This is a clever observation. I wonder if we should build it into JSObject, by providing a (fast?)getOwnProperty() that takes a JSString* argument. That would simplify some of the call sites, and it would encourage folks writing code that used JSString* to do the right thing by default.
Comment 3 Andreas Kling 2014-09-02 15:30:20 PDT 
Comment on attachment 237505 [details]
Patch

Clearing flags on attachment: 237505

Committed r173188: <http://trac.webkit.org/changeset/173188>
Comment 4 Andreas Kling 2014-09-02 15:30:22 PDT 
All reviewed patches have been landed.  Closing bug.