Bug 136446 - Clean up naming for and slightly refactor legacy video fullscreen support
Summary: Clean up naming for and slightly refactor legacy video fullscreen support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Maciej Stachowiak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-02 00:43 PDT by Maciej Stachowiak
Modified: 2014-09-03 17:27 PDT (History)
12 users (show)

See Also:

Attachments
Patch (117.31 KB, patch)
2014-09-02 01:17 PDT, Maciej Stachowiak 		no flags Details | Formatted Diff | Diff
Patch (117.66 KB, patch)
2014-09-02 11:09 PDT, Maciej Stachowiak 		no flags Details | Formatted Diff | Diff
Rebaselined to newer trunk (117.64 KB, patch)
2014-09-02 13:18 PDT, Maciej Stachowiak 		no flags Details | Formatted Diff | Diff
Attempt to fix Windows build (117.81 KB, patch)
2014-09-02 15:47 PDT, Maciej Stachowiak 		no flags Details | Formatted Diff | Diff
Patch (127.84 KB, patch)
2014-09-02 18:21 PDT, Maciej Stachowiak 		no flags Details | Formatted Diff | Diff
Try to fix Windows build again (127.84 KB, patch)
2014-09-03 00:15 PDT, Maciej Stachowiak 		jer.noble: review+
Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2014-09-02 00:43:14 PDT 
Clean up naming for and slightly refactor legacy video fullscreen support
Comment 1 Maciej Stachowiak 2014-09-02 01:17:11 PDT 
Created attachment 237481 [details]
Patch
Comment 2 WebKit Commit Bot 2014-09-02 01:18:47 PDT 
Attachment 237481 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ios/WebVideoFullscreenModelVideoElement.mm:41:  "WebCore/HTMLVideoElement.h" already included at Source/WebCore/platform/ios/WebVideoFullscreenModelVideoElement.mm:40  [build/include] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenModelVideoElement.mm:47:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenModelVideoElement.mm:57:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit/mac/WebView/WebView.mm:137:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/html/HTMLMediaElement.h:819:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 5 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Maciej Stachowiak 2014-09-02 11:09:40 PDT 
Created attachment 237507 [details]
Patch
Comment 4 Maciej Stachowiak 2014-09-02 13:18:09 PDT 
Created attachment 237510 [details]
Rebaselined to newer trunk
Comment 5 WebKit Commit Bot 2014-09-02 13:19:43 PDT 
Attachment 237510 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebView/WebView.mm:137:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/html/HTMLMediaElement.h:819:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 2 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Maciej Stachowiak 2014-09-02 15:47:49 PDT 
Created attachment 237523 [details]
Attempt to fix Windows build
Comment 7 WebKit Commit Bot 2014-09-02 15:49:20 PDT 
Attachment 237523 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebView/WebView.mm:137:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/html/HTMLMediaElement.h:819:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 2 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Maciej Stachowiak 2014-09-02 18:21:46 PDT 
Created attachment 237538 [details]
Patch
Comment 9 WebKit Commit Bot 2014-09-02 18:24:15 PDT 
Attachment 237538 [details] did not pass style-queue:


ERROR: Source/WebCore/WebCore.exp.in:0:  Source/WebCore/WebCore.exp.in should be sorted, use Tools/Scripts/sort-export-file script  [list/order] [5]
ERROR: Source/WebCore/html/HTMLMediaElement.h:819:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 2 in 33 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Maciej Stachowiak 2014-09-03 00:15:56 PDT 
Created attachment 237549 [details]
Try to fix Windows build again
Comment 11 WebKit Commit Bot 2014-09-03 00:17:28 PDT 
Attachment 237549 [details] did not pass style-queue:


ERROR: Source/WebCore/WebCore.exp.in:0:  Source/WebCore/WebCore.exp.in should be sorted, use Tools/Scripts/sort-export-file script  [list/order] [5]
ERROR: Source/WebCore/html/HTMLMediaElement.h:819:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 2 in 33 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 Jer Noble 2014-09-03 13:21:04 PDT 
Comment on attachment 237549 [details]
Try to fix Windows build again

There's a lot of really good refactoring in here. r=me
Comment 13 Maciej Stachowiak 2014-09-03 14:32:49 PDT 
Committed r173230: <http://trac.webkit.org/changeset/173230>
Comment 14 Tim Horton 2014-09-03 17:27:38 PDT 
Slightly weird iOS build fix in http://trac.webkit.org/changeset/173243