RESOLVED FIXED136446
Clean up naming for and slightly refactor legacy video fullscreen support 
https://bugs.webkit.org/show_bug.cgi?id=136446
Summary Clean up naming for and slightly refactor legacy video fullscreen support
Maciej Stachowiak
Reported 2014-09-02 00:43:14 PDT
Clean up naming for and slightly refactor legacy video fullscreen support
Attachments
Patch (117.31 KB, patch)
2014-09-02 01:17 PDT, Maciej Stachowiak 		no flags
DetailsFormatted DiffDiff
Patch (117.66 KB, patch)
2014-09-02 11:09 PDT, Maciej Stachowiak 		no flags
DetailsFormatted DiffDiff
Rebaselined to newer trunk (117.64 KB, patch)
2014-09-02 13:18 PDT, Maciej Stachowiak 		no flags
DetailsFormatted DiffDiff
Attempt to fix Windows build (117.81 KB, patch)
2014-09-02 15:47 PDT, Maciej Stachowiak 		no flags
DetailsFormatted DiffDiff
Patch (127.84 KB, patch)
2014-09-02 18:21 PDT, Maciej Stachowiak 		no flags
DetailsFormatted DiffDiff
Try to fix Windows build again (127.84 KB, patch)
2014-09-03 00:15 PDT, Maciej Stachowiak 		jer.noble: review+
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1 2014-09-02 01:17:11 PDT
Created attachment 237481 [details] Patch
WebKit Commit Bot
Comment 2 2014-09-02 01:18:47 PDT
Attachment 237481 [details] did not pass style-queue: ERROR: Source/WebCore/platform/ios/WebVideoFullscreenModelVideoElement.mm:41: "WebCore/HTMLVideoElement.h" already included at Source/WebCore/platform/ios/WebVideoFullscreenModelVideoElement.mm:40 [build/include] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenModelVideoElement.mm:47: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenModelVideoElement.mm:57: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/mac/WebView/WebView.mm:137: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/html/HTMLMediaElement.h:819: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] Total errors found: 5 in 31 files If any of these errors are false positives, please file a bug against check-webkit-style.
Maciej Stachowiak
Comment 3 2014-09-02 11:09:40 PDT
Created attachment 237507 [details] Patch
Maciej Stachowiak
Comment 4 2014-09-02 13:18:09 PDT
Created attachment 237510 [details] Rebaselined to newer trunk
WebKit Commit Bot
Comment 5 2014-09-02 13:19:43 PDT
Attachment 237510 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebView/WebView.mm:137: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/html/HTMLMediaElement.h:819: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] Total errors found: 2 in 31 files If any of these errors are false positives, please file a bug against check-webkit-style.
Maciej Stachowiak
Comment 6 2014-09-02 15:47:49 PDT
Created attachment 237523 [details] Attempt to fix Windows build
WebKit Commit Bot
Comment 7 2014-09-02 15:49:20 PDT
Attachment 237523 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebView/WebView.mm:137: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/html/HTMLMediaElement.h:819: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] Total errors found: 2 in 31 files If any of these errors are false positives, please file a bug against check-webkit-style.
Maciej Stachowiak
Comment 8 2014-09-02 18:21:46 PDT
Created attachment 237538 [details] Patch
WebKit Commit Bot
Comment 9 2014-09-02 18:24:15 PDT
Attachment 237538 [details] did not pass style-queue: ERROR: Source/WebCore/WebCore.exp.in:0: Source/WebCore/WebCore.exp.in should be sorted, use Tools/Scripts/sort-export-file script [list/order] [5] ERROR: Source/WebCore/html/HTMLMediaElement.h:819: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] Total errors found: 2 in 33 files If any of these errors are false positives, please file a bug against check-webkit-style.
Maciej Stachowiak
Comment 10 2014-09-03 00:15:56 PDT
Created attachment 237549 [details] Try to fix Windows build again
WebKit Commit Bot
Comment 11 2014-09-03 00:17:28 PDT
Attachment 237549 [details] did not pass style-queue: ERROR: Source/WebCore/WebCore.exp.in:0: Source/WebCore/WebCore.exp.in should be sorted, use Tools/Scripts/sort-export-file script [list/order] [5] ERROR: Source/WebCore/html/HTMLMediaElement.h:819: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] Total errors found: 2 in 33 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jer Noble
Comment 12 2014-09-03 13:21:04 PDT
Comment on attachment 237549 [details] Try to fix Windows build again There's a lot of really good refactoring in here. r=me
Maciej Stachowiak
Comment 13 2014-09-03 14:32:49 PDT
Committed r173230: <http://trac.webkit.org/changeset/173230>
Tim Horton
Comment 14 2014-09-03 17:27:38 PDT
Slightly weird iOS build fix in http://trac.webkit.org/changeset/173243
Note You need to log in before you can comment on or make changes to this bug.