Bug 136438 - Make DrawingArea a real MessageReceiver
Summary: Make DrawingArea a real MessageReceiver
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-01 15:41 PDT by Tim Horton
Modified: 2014-09-09 08:58 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.79 KB, patch)
2014-09-01 15:41 PDT, Tim Horton 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-09-01 15:41:01 PDT 
Make DrawingArea a real MessageReceiver
Comment 1 Tim Horton 2014-09-01 15:41:38 PDT 
Created attachment 237466 [details]
Patch
Comment 2 Darin Adler 2014-09-04 01:23:43 PDT 
Comment on attachment 237466 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237466&action=review

> Source/WebKit2/WebProcess/WebPage/DrawingArea.h:61
> +class DrawingArea : public IPC::MessageReceiver {

Can this derive privately instead of publicly? Just wondering.
Comment 3 Darin Adler 2014-09-04 01:24:14 PDT 
Comment on attachment 237466 [details]
Patch

Not sure why this breaks the EFL build. The EWS output doesn’t contain enough context for me to diagnose.
Comment 4 Tim Horton 2014-09-09 08:34:36 PDT 
(In reply to comment #3)
> (From update of attachment 237466 [details])
> Not sure why this breaks the EFL build. The EWS output doesn’t contain enough context for me to diagnose.

It's one of these:

c++: internal compiler error: Killed (program cc1plus)

which tend (usually) not to be the patch's fault.
Comment 5 Tim Horton 2014-09-09 08:49:19 PDT 
(In reply to comment #2)
> (From update of attachment 237466 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=237466&action=review
> 
> > Source/WebKit2/WebProcess/WebPage/DrawingArea.h:61
> > +class DrawingArea : public IPC::MessageReceiver {
> 
> Can this derive privately instead of publicly? Just wondering.

I don't think so, because MessageReceiverMap and friends need to be able to call the MessageReceiver functions. In any case, there's no precedent.
Comment 6 Tim Horton 2014-09-09 08:58:29 PDT 
http://trac.webkit.org/changeset/173429