Bug 136438 – Make DrawingArea a real MessageReceiver

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

Make DrawingArea a real MessageReceiver

[Tim Horton]

Created attachment 237466 [details]
Patch

[Darin Adler]

Comment on attachment 237466 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237466&action=review

> Source/WebKit2/WebProcess/WebPage/DrawingArea.h:61
> +class DrawingArea : public IPC::MessageReceiver {

Can this derive privately instead of publicly? Just wondering.

[Darin Adler]

Comment on attachment 237466 [details]
Patch

Not sure why this breaks the EFL build. The EWS output doesn’t contain enough context for me to diagnose.

[Tim Horton]

(In reply to comment #3)
> (From update of attachment 237466 [details])
> Not sure why this breaks the EFL build. The EWS output doesn’t contain enough context for me to diagnose.

It's one of these:

c++: internal compiler error: Killed (program cc1plus)

which tend (usually) not to be the patch's fault.

[Tim Horton]

(In reply to comment #2)
> (From update of attachment 237466 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=237466&action=review
> 
> > Source/WebKit2/WebProcess/WebPage/DrawingArea.h:61
> > +class DrawingArea : public IPC::MessageReceiver {
> 
> Can this derive privately instead of publicly? Just wondering.

I don't think so, because MessageReceiverMap and friends need to be able to call the MessageReceiver functions. In any case, there's no precedent.

[Tim Horton]

http://trac.webkit.org/changeset/173429