Bug 136420 - Remove unused ARMv6-specific #if branches in WebCore::canHyphenate
Summary: Remove unused ARMv6-specific #if branches in WebCore::canHyphenate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-31 18:03 PDT by Tim Horton
Modified: 2014-09-01 00:09 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.47 KB, patch)
2014-08-31 18:04 PDT, Tim Horton 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-08-31 18:03:28 PDT 
Remove unused ARMv6-specific #if branches in WebCore::canHyphenate
Comment 1 Tim Horton 2014-08-31 18:04:03 PDT 
Created attachment 237438 [details]
Patch
Comment 2 Tim Horton 2014-08-31 18:11:46 PDT 
http://trac.webkit.org/changeset/173151
Comment 3 Alexey Proskuryakov 2014-08-31 23:54:51 PDT 
Comment on attachment 237438 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237438&action=review

> Source/WebCore/ChangeLog:10
> +        Use kCFAllocatorDefault instead of 0.

Do we do that? I thought that 0 was better in nearly every respect - shorter and faster.
Comment 4 mitz 2014-08-31 23:56:26 PDT 
(In reply to comment #3)
> (From update of attachment 237438 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=237438&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        Use kCFAllocatorDefault instead of 0.
> 
> Do we do that? I thought that 0 was better in nearly every respect - shorter and faster.

Perhaps, but also completely mysterious when reading the code.
Comment 5 Alexey Proskuryakov 2014-09-01 00:09:39 PDT 
We do need a certain level of C++ knowledge and platform savviness from contributors. I don't think that we have any who actually find this mysterious.

I don't have any links, but I'm pretty sure that this was discussed before, and kCFAllocatorDefault was agreed unnecessary.