RESOLVED FIXED136420
Remove unused ARMv6-specific #if branches in WebCore::canHyphenate 
https://bugs.webkit.org/show_bug.cgi?id=136420
Summary Remove unused ARMv6-specific #if branches in WebCore::canHyphenate
Tim Horton
Reported 2014-08-31 18:03:28 PDT
Remove unused ARMv6-specific #if branches in WebCore::canHyphenate
Attachments
Patch (2.47 KB, patch)
2014-08-31 18:04 PDT, Tim Horton 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-08-31 18:04:03 PDT
Created attachment 237438 [details] Patch
Tim Horton
Comment 2 2014-08-31 18:11:46 PDT
http://trac.webkit.org/changeset/173151
Alexey Proskuryakov
Comment 3 2014-08-31 23:54:51 PDT
Comment on attachment 237438 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237438&action=review > Source/WebCore/ChangeLog:10 > + Use kCFAllocatorDefault instead of 0. Do we do that? I thought that 0 was better in nearly every respect - shorter and faster.
mitz
Comment 4 2014-08-31 23:56:26 PDT
(In reply to comment #3) > (From update of attachment 237438 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=237438&action=review > > > Source/WebCore/ChangeLog:10 > > + Use kCFAllocatorDefault instead of 0. > > Do we do that? I thought that 0 was better in nearly every respect - shorter and faster. Perhaps, but also completely mysterious when reading the code.
Alexey Proskuryakov
Comment 5 2014-09-01 00:09:39 PDT
We do need a certain level of C++ knowledge and platform savviness from contributors. I don't think that we have any who actually find this mysterious. I don't have any links, but I'm pretty sure that this was discussed before, and kCFAllocatorDefault was agreed unnecessary.
Note You need to log in before you can comment on or make changes to this bug.