WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
136413
Remove duplicate implementation of drawEllipse and some related PLATFORM(IOS) ifdefs
https://bugs.webkit.org/show_bug.cgi?id=136413
Summary
Remove duplicate implementation of drawEllipse and some related PLATFORM(IOS)...
Tim Horton
Reported
2014-08-31 02:35:19 PDT
Remove duplicate implementation of drawEllipse and some related PLATFORM(IOS) ifdefs
Attachments
Patch
(5.18 KB, patch)
2014-08-31 02:35 PDT
,
Tim Horton
no flags
Details
Formatted Diff
Diff
patch
(5.56 KB, patch)
2014-08-31 04:20 PDT
,
Tim Horton
mitz: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Tim Horton
Comment 1
2014-08-31 02:35:36 PDT
Created
attachment 237423
[details]
Patch
Tim Horton
Comment 2
2014-08-31 02:35:57 PDT
Have tested Mac, will test iOS as well shortly.
Tim Horton
Comment 3
2014-08-31 03:51:13 PDT
Hmm, nope, changes the rendering of radio buttons on iOS a little bit (border around the inner circle of a selected radio button grows a lot).
Tim Horton
Comment 4
2014-08-31 04:20:32 PDT
Created
attachment 237425
[details]
patch Actually, that was a preexisting issue with the initialization of the CGContext! (GraphicsContext line width defaults to 0, CGContext's to 1). Going to need to run the layout tests now...
Tim Horton
Comment 5
2014-08-31 04:43:27 PDT
Layout tests are happy.
Tim Horton
Comment 6
2014-08-31 15:04:14 PDT
http://trac.webkit.org/changeset/173149
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug