Bug 136413 - Remove duplicate implementation of drawEllipse and some related PLATFORM(IOS) ifdefs
Summary: Remove duplicate implementation of drawEllipse and some related PLATFORM(IOS)...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-31 02:35 PDT by Tim Horton
Modified: 2014-08-31 15:04 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.18 KB, patch)
2014-08-31 02:35 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
patch (5.56 KB, patch)
2014-08-31 04:20 PDT, Tim Horton 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-08-31 02:35:19 PDT 
Remove duplicate implementation of drawEllipse and some related PLATFORM(IOS) ifdefs
Comment 1 Tim Horton 2014-08-31 02:35:36 PDT 
Created attachment 237423 [details]
Patch
Comment 2 Tim Horton 2014-08-31 02:35:57 PDT 
Have tested Mac, will test iOS as well shortly.
Comment 3 Tim Horton 2014-08-31 03:51:13 PDT 
Hmm, nope, changes the rendering of radio buttons on iOS a little bit (border around the inner circle of a selected radio button grows a lot).
Comment 4 Tim Horton 2014-08-31 04:20:32 PDT 
Created attachment 237425 [details]
patch

Actually, that was a preexisting issue with the initialization of the CGContext! (GraphicsContext line width defaults to 0, CGContext's to 1).

Going to need to run the layout tests now...
Comment 5 Tim Horton 2014-08-31 04:43:27 PDT 
Layout tests are happy.
Comment 6 Tim Horton 2014-08-31 15:04:14 PDT 
http://trac.webkit.org/changeset/173149