RESOLVED FIXED 136394
Convert string literals to character literals in makeString usage 
https://bugs.webkit.org/show_bug.cgi?id=136394
Summary Convert string literals to character literals in makeString usage
Joseph Pecoraro
Reported 2014-08-29 16:16:59 PDT
There are some calls to makeString that use a string literal where it can use a character literal.
Attachments
[PATCH] Proposed Fix (8.27 KB, patch)
2014-08-29 16:19 PDT, Joseph Pecoraro 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (502.09 KB, application/zip)
2014-08-29 17:55 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (587.91 KB, application/zip)
2014-08-29 17:59 PDT, Build Bot 		no flags
Details
[PATCH] Proposed Fix (8.34 KB, patch)
2014-08-29 18:04 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2014-08-29 16:19:59 PDT
Created attachment 237387 [details] [PATCH] Proposed Fix
Build Bot
Comment 2 2014-08-29 17:55:56 PDT
Comment on attachment 237387 [details] [PATCH] Proposed Fix Attachment 237387 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6001914915323904 New failing tests: http/tests/security/contentSecurityPolicy/source-list-parsing-none.html
Build Bot
Comment 3 2014-08-29 17:55:59 PDT
Created attachment 237397 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Build Bot
Comment 4 2014-08-29 17:59:27 PDT
Comment on attachment 237387 [details] [PATCH] Proposed Fix Attachment 237387 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5663531621941248 New failing tests: http/tests/security/contentSecurityPolicy/source-list-parsing-none.html
Build Bot
Comment 5 2014-08-29 17:59:30 PDT
Created attachment 237398 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Joseph Pecoraro
Comment 6 2014-08-29 18:04:06 PDT
Created attachment 237399 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 7 2014-08-30 16:19:46 PDT
Comment on attachment 237399 [details] [PATCH] Proposed Fix Clearing flags on attachment: 237399 Committed r173142: <http://trac.webkit.org/changeset/173142>
WebKit Commit Bot
Comment 8 2014-08-30 16:19:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.