Bug 136394 - Convert string literals to character literals in makeString usage
Summary: Convert string literals to character literals in makeString usage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-29 16:16 PDT by Joseph Pecoraro
Modified: 2014-08-30 16:19 PDT (History)
6 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (8.27 KB, patch)
2014-08-29 16:19 PDT, Joseph Pecoraro 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (502.09 KB, application/zip)
2014-08-29 17:55 PDT, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (587.91 KB, application/zip)
2014-08-29 17:59 PDT, Build Bot 		no flags Details
[PATCH] Proposed Fix (8.34 KB, patch)
2014-08-29 18:04 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-08-29 16:16:59 PDT 
There are some calls to makeString that use a string literal where it can use a character literal.
Comment 1 Joseph Pecoraro 2014-08-29 16:19:59 PDT 
Created attachment 237387 [details]
[PATCH] Proposed Fix
Comment 2 Build Bot 2014-08-29 17:55:56 PDT 
Comment on attachment 237387 [details]
[PATCH] Proposed Fix

Attachment 237387 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6001914915323904

New failing tests:
http/tests/security/contentSecurityPolicy/source-list-parsing-none.html
Comment 3 Build Bot 2014-08-29 17:55:59 PDT 
Created attachment 237397 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 4 Build Bot 2014-08-29 17:59:27 PDT 
Comment on attachment 237387 [details]
[PATCH] Proposed Fix

Attachment 237387 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5663531621941248

New failing tests:
http/tests/security/contentSecurityPolicy/source-list-parsing-none.html
Comment 5 Build Bot 2014-08-29 17:59:30 PDT 
Created attachment 237398 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 6 Joseph Pecoraro 2014-08-29 18:04:06 PDT 
Created attachment 237399 [details]
[PATCH] Proposed Fix
Comment 7 WebKit Commit Bot 2014-08-30 16:19:46 PDT 
Comment on attachment 237399 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 237399

Committed r173142: <http://trac.webkit.org/changeset/173142>
Comment 8 WebKit Commit Bot 2014-08-30 16:19:49 PDT 
All reviewed patches have been landed.  Closing bug.