Bug 136384 - Crashes in IPC code under VisitedLinkProvider::pendingVisitedLinksTimerFired
Summary: Crashes in IPC code under VisitedLinkProvider::pendingVisitedLinksTimerFired
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-08-29 12:41 PDT by Alexey Proskuryakov
Modified: 2014-08-29 14:41 PDT (History)
4 users (show)

See Also:

Attachments
proposed patch (15.82 KB, patch)
2014-08-29 13:15 PDT, Alexey Proskuryakov 		sam: review-
Details | Formatted Diff | Diff
proposed fix (16.35 KB, patch)
2014-08-29 14:30 PDT, Alexey Proskuryakov 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-08-29 12:41:33 PDT 
rdar://problem/16991213
Comment 1 Alexey Proskuryakov 2014-08-29 13:15:42 PDT 
Created attachment 237370 [details]
proposed patch
Comment 2 WebKit Commit Bot 2014-08-29 13:16:56 PDT 
Attachment 237370 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebProcessProxy.cpp:39:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2014-08-29 13:25:15 PDT 
Comment on attachment 237370 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237370&action=review

> Source/WebKit2/UIProcess/VisitedLinkProvider.cpp:54
> +static HashSet<VisitedLinkProvider*>& allVisitedLinkProviders()
> +{
> +    ASSERT(RunLoop::isMain());
> +    static NeverDestroyed<HashSet<VisitedLinkProvider*>> providers;
> +    return providers;

I don't think these should be globals.  Instead, the WebProcessProxy should store this.
Comment 4 Alexey Proskuryakov 2014-08-29 14:30:26 PDT 
Created attachment 237378 [details]
proposed fix

Makes sense.
Comment 5 Alexey Proskuryakov 2014-08-29 14:41:31 PDT 
Committed <http://trac.webkit.org/changeset/173121>.