RESOLVED CONFIGURATION CHANGED136382
Remove Node::toInputElement() in favor of is/toHTMLInputElement(). 
https://bugs.webkit.org/show_bug.cgi?id=136382
Summary Remove Node::toInputElement() in favor of is/toHTMLInputElement().
Andreas Kling
Reported 2014-08-29 12:27:08 PDT
We should use the generated node conversion helpers instead of having a virtual toInputElement().
Attachments
Patch (32.57 KB, patch)
2014-08-29 14:16 PDT, Andreas Kling 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (732.19 KB, application/zip)
2014-08-29 16:12 PDT, Build Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-08-29 14:16:34 PDT
Created attachment 237376 [details] Patch
Build Bot
Comment 2 2014-08-29 16:12:20 PDT
Comment on attachment 237376 [details] Patch Attachment 237376 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5216322984083456 New failing tests: fast/files/read-file-async.html fast/files/workers/worker-read-blob-sync.html fast/files/file-reader-directory-crash.html http/tests/local/blob/send-hybrid-blob.html fast/files/workers/worker-read-file-async.html fast/files/apply-blob-url-to-xhr.html fast/files/file-list-test.html fast/forms/file/input-file-re-render.html fast/files/file-reader-abort.html fast/files/null-origin-string.html fast/files/workers/worker-read-file-sync.html fast/files/workers/worker-apply-blob-url-to-xhr.html accessibility/file-upload-button-stringvalue.html fast/workers/worker-copy-shared-blob-url.html fast/forms/range/range-type-change-oninput.html fast/forms/range/range-type-change-onchange-2.html fast/files/read-blob-async.html fast/forms/file/get-file-upload.html fast/files/workers/worker-read-blob-async.html
Build Bot
Comment 3 2014-08-29 16:12:22 PDT
Created attachment 237386 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Darin Adler
Comment 4 2014-09-04 01:19:46 PDT
I believe toInputElement is a leftover from our long ago deleted WML support!
Anne van Kesteren
Comment 5 2023-05-12 23:46:47 PDT
% git grep toInputElement Source Source/WebCore/WebCore.order:__ZN7WebCore4Node14toInputElementEv Source/WebCore/WebCore.order:__ZN7WebCore16HTMLInputElement14toInputElementEv
Note You need to log in before you can comment on or make changes to this bug.