Bug 136381 - LegacyProfiler: ProfileNodes should be used more like structs
Summary: LegacyProfiler: ProfileNodes should be used more like structs
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brian Burg
Depends on: 136380
Blocks: 136352
  Show dependency treegraph
Reported: 2014-08-29 12:14 PDT by Brian Burg
Modified: 2014-09-04 10:00 PDT (History)
0 users

See Also:

Patch (20.24 KB, patch)
2014-09-01 18:10 PDT, Brian Burg
no flags Details | Formatted Diff | Diff
Fix test failures (21.16 KB, patch)
2014-09-01 20:29 PDT, Brian Burg
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-08-29 12:14:57 PDT
They do too much stuff now that the ProfileGenerator should be doing instead.
Comment 1 Brian Burg 2014-09-01 18:10:19 PDT
Created attachment 237471 [details]
Comment 2 Brian Burg 2014-09-01 18:12:20 PDT
This won't compile unless on top of 136380's changes. I am fine with combining the two patches, but it would be an even bigger pain to review.
Comment 3 Brian Burg 2014-09-01 20:29:18 PDT
Created attachment 237474 [details]
Fix test failures
Comment 4 Brian Burg 2014-09-04 10:00:31 PDT
Committed r173262: <http://trac.webkit.org/changeset/173262>