Bug 136378 - WebPageProxy::close() is a no-op for terminated processes
Summary: WebPageProxy::close() is a no-op for terminated processes
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Depends on:
Reported: 2014-08-29 11:45 PDT by Alexey Proskuryakov
Modified: 2014-08-29 14:23 PDT (History)
4 users (show)

See Also:

proposed fix (3.82 KB, patch)
2014-08-29 11:53 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-08-29 11:45:41 PDT
WebPageProxy::close() has some clean-up that should happen regardless of whether the page has a running process, but it is a no-op when isValid() returns false.
Comment 1 Alexey Proskuryakov 2014-08-29 11:46:25 PDT
Related to <rdar://problem/16991213> and to <rdar://problem/17095600>.
Comment 2 Alexey Proskuryakov 2014-08-29 11:53:00 PDT
Created attachment 237366 [details]
proposed fix
Comment 3 Brady Eidson 2014-08-29 13:22:48 PDT
Comment on attachment 237366 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=237366&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:555
> +    m_process->removeMessageReceiver(Messages::WebPageProxy::messageReceiverName(), m_pageID);

Comment 4 WebKit Commit Bot 2014-08-29 14:23:38 PDT
Comment on attachment 237366 [details]
proposed fix

Clearing flags on attachment: 237366

Committed r173118: <http://trac.webkit.org/changeset/173118>
Comment 5 WebKit Commit Bot 2014-08-29 14:23:41 PDT
All reviewed patches have been landed.  Closing bug.