RESOLVED FIXED136360
Web Inspector: Fixes to layout test infrastructure 
https://bugs.webkit.org/show_bug.cgi?id=136360
Summary Web Inspector: Fixes to layout test infrastructure
Matt Baker
Reported 2014-08-28 18:53:25 PDT
We currently skip ALL inspector layout tests, to avoid assertions which occur during a handful of tests (https://bugs.webkit.org/show_bug.cgi?id=129642). Recommend skipping only tests in inspector/replay.
Attachments
Patch (4.26 KB, patch)
2014-09-02 16:35 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Patch (4.14 KB, patch)
2014-09-02 17:15 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-08-28 18:53:33 PDT
<rdar://problem/18170451>
Joseph Pecoraro
Comment 2 2014-08-29 11:25:00 PDT
TestExpectations already had a bug covering skipping all inspector tests: > webkit.org/b/129642 inspector [ Skip ] <https://webkit.org/b/129642> StorageTracker::deleteOrigin being called off the main thread (ASSERTs in inspector/test-harness-trivially-works.html test)
Matt Baker
Comment 3 2014-09-02 16:35:29 PDT
Created attachment 237531 [details] Patch
Matt Baker
Comment 4 2014-09-02 16:50:54 PDT
Assertions still occur outside of inspector/replay, so for now we'll continue to skip all inspector tests. This issue is intended to address a couple unrelated bugs which were discovered while investigating https://bugs.webkit.org/show_bug.cgi?id=129642.
Joseph Pecoraro
Comment 5 2014-09-02 16:53:11 PDT
Comment on attachment 237531 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237531&action=review r=me, update the ChangeLog with the new bug title before landing. > LayoutTests/ChangeLog:9 > + Updated expected results to reflect changes to breakpoint resolution in > + issue: https://bugs.webkit.org/show_bug.cgi?id=135396. Instead of referencing the bug, you should reference the r####.
Matt Baker
Comment 6 2014-09-02 17:15:30 PDT
Created attachment 237534 [details] Patch
Joseph Pecoraro
Comment 7 2014-09-02 17:16:45 PDT
Comment on attachment 237534 [details] Patch r=me
WebKit Commit Bot
Comment 8 2014-09-08 16:59:16 PDT
Comment on attachment 237534 [details] Patch Clearing flags on attachment: 237534 Committed r173405: <http://trac.webkit.org/changeset/173405>
WebKit Commit Bot
Comment 9 2014-09-08 16:59:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.