Bug 136359 - move emissions of op_profile_type out of BytecodeGenerator::emitMove
Summary: move emissions of op_profile_type out of BytecodeGenerator::emitMove
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-28 17:44 PDT by Saam Barati
Modified: 2015-08-13 13:52 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2014-08-28 17:44:52 PDT 
Currently, this will emit an op_profile_type if it sees that the destination register isn't a temporary.
And in NodesCodegen, after these emitMove calls, there will be calls to generator::emitTypeProfilerExpressionInfo.
But, just by reading the code in NodesCodegen, it's confusing why this expression info is emitted.
It's better to just inline the emission of op_profile_type everywhere emitTypeProfilerExpressionInfo is called.
Comment 1 Saam Barati 2015-08-13 13:52:16 PDT 
this was done in:
http://trac.webkit.org/changeset/187524