Bug 136356 - Occasional thread-safety-related crashes on the ServicesController queue
Summary: Occasional thread-safety-related crashes on the ServicesController queue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-08-28 16:44 PDT by Tim Horton
Modified: 2014-08-28 16:58 PDT (History)
6 users (show)

See Also:

Attachments
patch (4.95 KB, patch)
2014-08-28 16:47 PDT, Tim Horton 		mitz: review+
Details | Formatted Diff | Diff
patch (5.52 KB, patch)
2014-08-28 16:53 PDT, Tim Horton 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-08-28 16:44:31 PDT 
We shouldn't use API that makes an NSMenu anywhere but the main thread.

Instead, use alternate SPI.

rdar://problem/18045685
Comment 1 Tim Horton 2014-08-28 16:47:48 PDT 
Created attachment 237330 [details]
patch
Comment 2 mitz 2014-08-28 16:52:39 PDT 
Comment on attachment 237330 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237330&action=review

> Source/WebKit2/UIProcess/mac/ServicesController.mm:109
> +    NSSharingServiceMask serviceMask = NSSharingServiceMaskViewer | NSSharingServiceMaskEditor;

I don’t see why this variable is needed.

> Source/WebKit2/UIProcess/mac/ServicesController.mm:110
> +    return [[NSSharingService sharingServicesForItems:items mask:serviceMask] count];

You can use .count notation here!
Comment 3 Tim Horton 2014-08-28 16:53:27 PDT 
Created attachment 237331 [details]
patch
Comment 4 mitz 2014-08-28 16:55:09 PDT 
Comment on attachment 237331 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237331&action=review

> Source/WebKit2/UIProcess/mac/ServicesController.mm:115
> +    NSSharingServiceMask serviceMask = NSSharingServiceMaskViewer | NSSharingServiceMaskEditor;

:-|
Comment 5 WebKit Commit Bot 2014-08-28 16:56:18 PDT 
Attachment 237331 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/ServicesController.mm:52:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Tim Horton 2014-08-28 16:58:40 PDT 
http://trac.webkit.org/changeset/173092