Bug 136356 – Occasional thread-safety-related crashes on the ServicesController queue

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Tim Horton]

We shouldn't use API that makes an NSMenu anywhere but the main thread.

Instead, use alternate SPI.

rdar://problem/18045685

[Tim Horton]

Created attachment 237330 [details]
patch

Comment on attachment 237330 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237330&action=review

> Source/WebKit2/UIProcess/mac/ServicesController.mm:109
> +    NSSharingServiceMask serviceMask = NSSharingServiceMaskViewer | NSSharingServiceMaskEditor;

I don’t see why this variable is needed.

> Source/WebKit2/UIProcess/mac/ServicesController.mm:110
> +    return [[NSSharingService sharingServicesForItems:items mask:serviceMask] count];

You can use .count notation here!

[Tim Horton]

Created attachment 237331 [details]
patch

Comment on attachment 237331 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237331&action=review

> Source/WebKit2/UIProcess/mac/ServicesController.mm:115
> +    NSSharingServiceMask serviceMask = NSSharingServiceMaskViewer | NSSharingServiceMaskEditor;

:-|

[WebKit Commit Bot]

Attachment 237331 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/ServicesController.mm:52:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

http://trac.webkit.org/changeset/173092