Bug 136345 – Add 'initial' keyword support for scroll snap CSS properties

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Jon Lee]

Scroll snap CSS properties need to support "initial" value

[Radar WebKit Bug Importer]

<rdar://problem/18162325>

[Brent Fulgham]

According to CSS Scroll Snap Points Module Level 1, 6 November 2014 Draft:

scroll-snap-type: none
scroll-snap-points-x: none
scroll-snap-points-y: none
scroll-snap-destination: 0px 0px
scroll-snap-coordinate: none

[Brent Fulgham]

Created attachment 248102 [details]
Patch

[Dean Jackson]

Comment on attachment 248102 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248102&action=review

> Source/WebCore/css/StyleBuilderCustom.h:1709
> +}
> +inline void StyleBuilderCustom::applyInheritWebkitScrollSnapPointsX(StyleResolver& styleResolver)
> +{
> +    styleResolver.style()->setScrollSnapPointsX(styleResolver.parentStyle()->scrollSnapPointsX() ? std::make_unique<ScrollSnapPoints>(*styleResolver.parentStyle()->scrollSnapPointsX()) : nullptr);

Maybe you want some blank lines to separate methods here.

> Source/WebCore/css/StyleBuilderCustom.h:1721
> +#endif
> +
> +    

Two lines.

[Brent Fulgham]

Comment on attachment 248102 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248102&action=review

>> Source/WebCore/css/StyleBuilderCustom.h:1709
>> +    styleResolver.style()->setScrollSnapPointsX(styleResolver.parentStyle()->scrollSnapPointsX() ? std::make_unique<ScrollSnapPoints>(*styleResolver.parentStyle()->scrollSnapPointsX()) : nullptr);
> 
> Maybe you want some blank lines to separate methods here.

OK!

>> Source/WebCore/css/StyleBuilderCustom.h:1721
>> +    
> 
> Two lines.

OK!

[Brent Fulgham]

The test failures on mac/mac-wk2 are because I forgot to rebaseline the scroll-snap-property-computed-styles test after correcting the 'initial' case. I'll correct while landing.

[Brent Fulgham]

Committed r181189: <http://trac.webkit.org/changeset/181189>