RESOLVED FIXED 136341
Subpixel layout: Remove unused pixel snapping functions. 
https://bugs.webkit.org/show_bug.cgi?id=136341
Summary Subpixel layout: Remove unused pixel snapping functions.
zalan
Reported 2014-08-28 08:57:19 PDT
and remove some that's still in use so that we stop using them. (most of them should go away anyway in long run)
Attachments
Patch (26.23 KB, patch)
2014-08-28 09:31 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (27.73 KB, patch)
2014-08-28 11:20 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2014-08-28 09:31:02 PDT
Created attachment 237315 [details] Patch
WebKit Commit Bot
Comment 2 2014-08-28 09:33:36 PDT
Attachment 237315 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderScrollbar.cpp:277: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/rendering/RenderScrollbar.cpp:278: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/rendering/RenderScrollbar.cpp:284: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/rendering/RenderScrollbar.cpp:285: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/rendering/RenderScrollbar.cpp:290: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/rendering/RenderScrollbar.cpp:291: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/rendering/RenderScrollbar.cpp:292: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 7 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
zalan
Comment 3 2014-08-28 11:20:55 PDT
Created attachment 237319 [details] Patch
WebKit Commit Bot
Comment 4 2014-08-28 11:23:36 PDT
Attachment 237319 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderScrollbar.cpp:277: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/rendering/RenderScrollbar.cpp:278: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/rendering/RenderScrollbar.cpp:284: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/rendering/RenderScrollbar.cpp:285: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/rendering/RenderScrollbar.cpp:290: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/rendering/RenderScrollbar.cpp:291: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/rendering/RenderScrollbar.cpp:292: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 7 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 5 2014-08-28 12:49:03 PDT
Comment on attachment 237319 [details] Patch Clearing flags on attachment: 237319 Committed r173073: <http://trac.webkit.org/changeset/173073>
WebKit Commit Bot
Comment 6 2014-08-28 12:49:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.