RESOLVED FIXED 136331
DFG should have a reusable SSA builder 
https://bugs.webkit.org/show_bug.cgi?id=136331
Summary DFG should have a reusable SSA builder
Filip Pizlo
Reported 2014-08-27 21:35:49 PDT
...
Attachments
it's a start (17.41 KB, patch)
2014-09-02 19:55 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
more (29.02 KB, patch)
2014-09-03 15:56 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
it begins (5.56 KB, patch)
2014-09-05 17:10 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
more (12.16 KB, patch)
2014-09-06 12:10 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
pretty close (16.92 KB, patch)
2014-09-06 13:59 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
it is written! (43.28 KB, patch)
2014-09-06 20:19 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
it compiles! (56.23 KB, patch)
2014-09-07 09:43 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
it ran something without crashing! (61.41 KB, patch)
2014-09-07 10:33 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
it can run bigger programs (75.32 KB, patch)
2014-09-08 11:32 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (77.17 KB, patch)
2014-09-08 12:26 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (77.79 KB, patch)
2014-09-08 12:31 PDT, Filip Pizlo 		oliver: review+
DetailsFormatted DiffDiff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-09-02 19:55:14 PDT
Created attachment 237543 [details] it's a start
Filip Pizlo
Comment 2 2014-09-03 15:56:24 PDT
Created attachment 237595 [details] more
Filip Pizlo
Comment 3 2014-09-03 19:44:00 PDT
Comment on attachment 237595 [details] more Obsoleted by https://bugs.webkit.org/attachment.cgi?id=237606&action=review
Filip Pizlo
Comment 4 2014-09-05 17:10:17 PDT
Created attachment 237725 [details] it begins
Filip Pizlo
Comment 5 2014-09-06 12:10:58 PDT
Created attachment 237741 [details] more
Filip Pizlo
Comment 6 2014-09-06 13:59:43 PDT
Created attachment 237743 [details] pretty close
Filip Pizlo
Comment 7 2014-09-06 20:19:38 PDT
Created attachment 237750 [details] it is written!
Filip Pizlo
Comment 8 2014-09-07 09:43:09 PDT
Created attachment 237754 [details] it compiles! It instacrashes though. I'll try to fix that.
Filip Pizlo
Comment 9 2014-09-07 10:33:07 PDT
Created attachment 237755 [details] it ran something without crashing! It can now SSA convert marsaglia.
Filip Pizlo
Comment 10 2014-09-08 11:32:50 PDT
Created attachment 237799 [details] it can run bigger programs
Filip Pizlo
Comment 11 2014-09-08 12:26:29 PDT
Created attachment 237802 [details] the patch I'm still going to do some perf tests for sanity but I don't expect to see any difference since these changes are engineered to not be observable.
WebKit Commit Bot
Comment 12 2014-09-08 12:27:53 PDT
Attachment 237802 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGSSACalculator.h:250: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 1 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 13 2014-09-08 12:31:51 PDT
Created attachment 237804 [details] the patch Fix style, add more comments.
Filip Pizlo
Comment 14 2014-09-08 17:35:51 PDT
Landed in http://trac.webkit.org/changeset/173413
Note You need to log in before you can comment on or make changes to this bug.