Bug 136323 - textStylingAtPosition returns incorrect values after executing toggleBold, toggleItalic and toggleUnderline
Summary: textStylingAtPosition returns incorrect values after executing toggleBold, to...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-08-27 17:11 PDT by Enrica Casucci
Modified: 2015-01-06 12:39 PST (History)
2 users (show)

See Also:

Attachments
Patch (6.31 KB, patch)
2014-08-27 17:22 PDT, Enrica Casucci 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2014-08-27 17:11:43 PDT 
textStylingAtPosition should always reflect the current style. It returns incorrect values when called after executing one of the toggle styling commands.

rdar://problem/18141964
Comment 1 Enrica Casucci 2014-08-27 17:22:06 PDT 
Created attachment 237272 [details]
Patch
Comment 2 Antti Koivisto 2014-08-27 17:58:07 PDT 
Comment on attachment 237272 [details]
Patch

Looks good.

It would be nice if we could at some point have only one copy of this and perhaps also eliminate the whole insert-and-remove-span-to-figure-out-style hack.
Comment 3 David Kilzer (:ddkilzer) 2015-01-06 12:39:49 PST 
Committed revision 173071.
<http://trac.webkit.org/changeset/173071>