RESOLVED FIXED 136317
Dashboard metrics page sometimes shows 0 for best time 
https://bugs.webkit.org/show_bug.cgi?id=136317
Summary Dashboard metrics page sometimes shows 0 for best time
Alexey Proskuryakov
Reported 2014-08-27 15:11:27 PDT
The metrics page filters out iterations that ended up with EXCEPTION or RETRY, but it doesn't filter out ones that failed due to infrastructure misbehaving. For example, a failure to download built archive counts as if it provided testing results for this revision. This happens quickly, so we get an incorrect small result for the elapsed time. We should be more selective about which iterations we consider productive.
Attachments
proposed fix (3.99 KB, patch)
2014-08-27 15:17 PDT, Alexey Proskuryakov 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-08-27 15:17:37 PDT
Created attachment 237262 [details] proposed fix
Tim Horton
Comment 2 2014-08-27 15:26:49 PDT
Comment on attachment 237262 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=237262&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:71 > +BuildbotIteration.ProductiveSteps = { Not an array? > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:295 > + var finishedAProductiveStep = false; s/A/Any/?
Alexey Proskuryakov
Comment 3 2014-08-27 15:36:17 PDT
Committed <http://trac.webkit.org/r173027>. > Not an array? I do an "in" on it, which should be faster than an indexOf on an array.
Note You need to log in before you can comment on or make changes to this bug.