Bug 136317 - Dashboard metrics page sometimes shows 0 for best time
Summary: Dashboard metrics page sometimes shows 0 for best time
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-27 15:11 PDT by Alexey Proskuryakov
Modified: 2014-08-27 15:36 PDT (History)
5 users (show)

See Also:


Attachments
proposed fix (3.99 KB, patch)
2014-08-27 15:17 PDT, Alexey Proskuryakov
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-08-27 15:11:27 PDT
The metrics page filters out iterations that ended up with EXCEPTION or RETRY, but it doesn't filter out ones that failed due to infrastructure misbehaving. For example, a failure to download built archive counts as if it provided testing results for this revision. This happens quickly, so we get an incorrect small result for the elapsed time.

We should be more selective about which iterations we consider productive.
Comment 1 Alexey Proskuryakov 2014-08-27 15:17:37 PDT
Created attachment 237262 [details]
proposed fix
Comment 2 Tim Horton 2014-08-27 15:26:49 PDT
Comment on attachment 237262 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=237262&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:71
> +BuildbotIteration.ProductiveSteps = {

Not an array?

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:295
> +            var finishedAProductiveStep = false;

s/A/Any/?
Comment 3 Alexey Proskuryakov 2014-08-27 15:36:17 PDT
Committed <http://trac.webkit.org/r173027>.

> Not an array?

I do an "in" on it, which should be faster than an indexOf on an array.