Bug 136314 - Subpixel layout: Rename FloatPoint/FloatRect device pixel snapping functions.
Summary: Subpixel layout: Rename FloatPoint/FloatRect device pixel snapping functions.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks: 136275
  Show dependency treegraph
 
Reported: 2014-08-27 14:55 PDT by zalan
Modified: 2014-08-27 20:33 PDT (History)
2 users (show)

See Also:


Attachments
Patch (9.45 KB, patch)
2014-08-27 15:14 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (9.46 KB, patch)
2014-08-27 19:50 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-08-27 14:55:52 PDT
to the new naming style of round/ceil/floor*ToDevicePixels. * = point/rect.
Comment 1 zalan 2014-08-27 15:14:18 PDT
Created attachment 237259 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-08-27 16:18:41 PDT
Comment on attachment 237259 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237259&action=review

> Source/WebCore/platform/graphics/FloatRect.cpp:209
> +FloatRect enclosingRectToDevicePixels(const FloatRect& rect, float deviceScaleFactor)

encloseRectToDevicePixels
Comment 3 zalan 2014-08-27 19:50:38 PDT
Created attachment 237281 [details]
Patch
Comment 4 WebKit Commit Bot 2014-08-27 20:33:16 PDT
Comment on attachment 237281 [details]
Patch

Clearing flags on attachment: 237281

Committed r173045: <http://trac.webkit.org/changeset/173045>
Comment 5 WebKit Commit Bot 2014-08-27 20:33:19 PDT
All reviewed patches have been landed.  Closing bug.