Bug 136309 - Occasional crashes in commitTransientZoom's transaction completion block
Summary: Occasional crashes in commitTransientZoom's transaction completion block
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-08-27 14:14 PDT by Tim Horton
Modified: 2014-08-27 16:01 PDT (History)
4 users (show)

See Also:

Attachments
patch (2.26 KB, patch)
2014-08-27 14:16 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
patch (2.90 KB, patch)
2014-08-27 15:29 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
fix changelog (2.22 KB, patch)
2014-08-27 15:30 PDT, Tim Horton 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-08-27 14:14:44 PDT 
<rdar://problem/17215064>
Comment 1 Tim Horton 2014-08-27 14:16:58 PDT 
Created attachment 237251 [details]
patch
Comment 2 WebKit Commit Bot 2014-08-27 14:18:07 PDT 
Attachment 237251 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:653:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2014-08-27 14:28:23 PDT 
Comment on attachment 237251 [details]
patch

Clearing r? because Dan pointed out some horrors.
Comment 4 Tim Horton 2014-08-27 15:29:50 PDT 
Created attachment 237263 [details]
patch
Comment 5 Tim Horton 2014-08-27 15:30:36 PDT 
Created attachment 237264 [details]
fix changelog
Comment 6 WebKit Commit Bot 2014-08-27 15:31:54 PDT 
Attachment 237264 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:644:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Tim Horton 2014-08-27 16:01:44 PDT 
http://trac.webkit.org/changeset/173029